r60251 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60250‎ | r60251 | r60252 >
Date:04:00, 21 December 2009
Author:aaron
Status:ok
Tags:
Comment:
Changed r52871 spacing style to match the rest
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -897,11 +897,11 @@
898898 return true; // simple custom levels set for action=protect
899899 }
900900 $title = $this->article->getTitle()->getSubjectPage();
901 - if ( !FlaggedRevs::isPageReviewable( $title ) ) {
 901+ if( !FlaggedRevs::isPageReviewable( $title ) ) {
902902 return true; // Only reviewable pages need these tabs
903903 }
904904 // Check if we should show a stabilization tab
905 - if (
 905+ if(
906906 !$skin->mTitle->isTalkPage() &&
907907 is_array( $actions ) &&
908908 !isset( $actions['protect'] ) &&
@@ -934,7 +934,7 @@
935935 $fa = FlaggedArticle::getTitleInstance( $title );
936936
937937 $action = $wgRequest->getVal( 'action', 'view' );
938 - if ( !$fa->isReviewable() || $fa->limitedUI() ) {
 938+ if( !$fa->isReviewable() || $fa->limitedUI() ) {
939939 return true; // Not a reviewable page or the UI is hidden
940940 }
941941 $flags = ($action == 'rollback') ? FR_MASTER : 0;
@@ -944,25 +944,25 @@
945945 }
946946 $synced = FlaggedRevs::stableVersionIsSynced( $srev, $fa );
947947 // Set draft tab as needed...
948 - if ( !$skin->mTitle->isTalkPage() && !$synced ) {
949 - if ( isset( $views['edit'] ) ) {
950 - if ( $fa->showStableByDefault() ) {
 948+ if( !$skin->mTitle->isTalkPage() && !$synced ) {
 949+ if( isset( $views['edit'] ) ) {
 950+ if( $fa->showStableByDefault() ) {
951951 $views['edit']['text'] = wfMsg('revreview-edit');
952952 }
953 - if ( $this->pageOverride() ) {
 953+ if( $this->pageOverride() ) {
954954 $views['edit']['href'] = $title->getLocalUrl( 'action=edit' );
955955 }
956956 }
957 - if ( isset( $views['viewsource'] ) ) {
958 - if ( $fa->showStableByDefault() ) {
 957+ if( isset( $views['viewsource'] ) ) {
 958+ if( $fa->showStableByDefault() ) {
959959 $views['viewsource']['text'] = wfMsg('revreview-source');
960960 }
961 - if ( $this->pageOverride() ) {
 961+ if( $this->pageOverride() ) {
962962 $views['viewsource']['href'] = $title->getLocalUrl( 'action=edit' );
963963 }
964964 }
965965 }
966 - if ( !FlaggedRevs::showVersionTabs() || $synced ) {
 966+ if( !FlaggedRevs::showVersionTabs() || $synced ) {
967967 // Exit, since either the stable/draft tabs should not be shown
968968 // or the page is already the most current revision
969969 return true;
@@ -979,10 +979,10 @@
980980 'class' => ''
981981 ),
982982 );
983 - if ( $this->pageOverride() || $wgRequest->getVal( 'stableid' ) ) {
 983+ if( $this->pageOverride() || $wgRequest->getVal( 'stableid' ) ) {
984984 // We are looking a the stable version
985985 $tabs['stable']['class'] = 'selected';
986 - } elseif (
 986+ } elseif(
987987 ( self::isViewAction( $action ) || $action == 'edit' ) &&
988988 !$skin->mTitle->isTalkPage()
989989 ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52871Broke out parts of FlaggedArticle::setActionTabs into FlaggedArticle::setView...tparscal23:10, 7 July 2009

Status & tagging log