r60242 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60241‎ | r60242 | r60243 >
Date:16:16, 20 December 2009
Author:ialex
Status:deferred
Tags:
Comment:
Fixes for r60241:
* Of course this doesn't work for pg since it doesn't use $wgUpdates
* consistency in OpenIDHooks::makeUoiUserNotUnique()
Modified paths:
  • /trunk/extensions/OpenID/OpenID.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.hooks.php
@@ -183,7 +183,9 @@
184184 $wgUpdates['mysql'][] = array( array( __CLASS__, 'makeUoiUserNotUnique' ) );
185185 } else if ( $wgDBtype == 'postgres' ) {
186186 $wgExtNewTables[] = array( 'user_openid', "$base/openid_table.pg.sql" );
187 - $wgUpdates['postgres'][] = array( array( __CLASS__, 'makeUoiUserNotUnique' ) );
 187+ # This doesn't work since MediaWiki doesn't use $wgUpdates when
 188+ # updating a PostgreSQL database
 189+ #$wgUpdates['postgres'][] = array( array( __CLASS__, 'makeUoiUserNotUnique' ) );
188190 }
189191
190192 return true;
@@ -200,7 +202,7 @@
201203 $db->sourceFile( dirname( __FILE__ ) . '/patch-uoi_user-not-unique.sql' );
202204 wfOut( " done.\n" );
203205 } else {
204 - wfOut( "...uoi_user field is already not unique\n" );
 206+ wfOut( "...uoi_user field is already not unique.\n" );
205207 }
206208 }
207209

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60241* (bug 19348) patch-uoi_user-not-unique.sql is now automatically applied in m...ialex16:07, 20 December 2009

Status & tagging log