r60238 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r60237‎ | r60238 | r60239 >
Date:11:18, 20 December 2009
Author:thomasv
Status:ok (Comments)
Tags:
Comment:
apparently, self.skin cannot be relied upon in current versions
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/proofread.js
——@@ -2,9 +2,8 @@
33
44
55 function pr_init_tabs(){
6 - var a;
7 - if ( self.skin=="vector" ) a = document.getElementById("p-namespaces");
8 - else var a = document.getElementById("p-cactions");
 6+ var a = document.getElementById("p-namespaces");
 7+ if(!a) a = document.getElementById("p-cactions");
98
109 if (!a) return;
1110 var b = a.getElementsByTagName("ul");

Comments

#Comment by Catrope (talk | contribs)   13:49, 20 December 2009

It should still be there. Try using skin instead of self.skin

#Comment by ThomasV (talk | contribs)   09:36, 21 December 2009

it is there but its value is "monobook", whether I use monobook or vector.

Status & tagging log