r60209 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60208‎ | r60209 | r60210 >
Date:17:19, 18 December 2009
Author:aaron
Status:ok
Tags:
Comment:
Removed $wgReviewChangesAfterEdit; now always on (no WMF site change)
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -100,8 +100,6 @@
101101
102102 # Can users make comments that will show up below flagged revisions?
103103 $wgFlaggedRevsComments = false;
104 -# Redirect users out to review changes since stable version on save?
105 -$wgReviewChangesAfterEdit = true;
106104 # Allow auto-review edits directly to the stable version by reviewers?
107105 # 1 to allow auto-sighting; 2 for auto-quality; 3 for auto-pristine
108106 $wgFlaggedRevsAutoReview = 1;
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -138,15 +138,6 @@
139139 global $wgUser, $wgSimpleFlaggedRevsUI;
140140 return $wgUser->getOption( 'flaggedrevssimpleui', intval($wgSimpleFlaggedRevsUI) );
141141 }
142 -
143 - /**
144 - * Redirect users out to review changes since stable version on save?
145 - * @returns bool
146 - */
147 - public static function reviewAfterEdit() {
148 - global $wgReviewChangesAfterEdit;
149 - return (bool)$wgReviewChangesAfterEdit;
150 - }
151142
152143 /**
153144 * Allow auto-review edits directly to the stable version by reviewers?
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -1268,9 +1268,9 @@
12691269 return true;
12701270 # Get latest revision Id (lag safe)
12711271 $latest = $this->article->getTitle()->getLatestRevID(GAID_FOR_UPDATE);
1272 - // If we are supposed to review after edit, and it was not autoreviewed,
1273 - // and the user can actually make new stable version, take us to the diff...
1274 - if( FlaggedRevs::reviewAfterEdit() && $latest > $frev->getRevId() && $frev->userCanSetFlags() ) {
 1272+ // If the edit was not autoreviewed, and the user can actually make a
 1273+ // new stable version, then go to the diff...
 1274+ if( $latest > $frev->getRevId() && $frev->userCanSetFlags() ) {
12751275 $extraQuery .= $extraQuery ? '&' : '';
12761276 $extraQuery .= "oldid={$frev->getRevId()}&diff=cur&diffonly=0"; // override diff-only
12771277 // ...otherwise, go to the current revision after completing an edit.

Status & tagging log