r60126 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60125‎ | r60126 | r60127 >
Date:18:51, 16 December 2009
Author:aaron
Status:ok
Tags:
Comment:
* Don't show precedence if there is only 1 level
* Depreciate -> Deprecate
Modified paths:
  • /trunk/extensions/FlaggedRevs/language/QualityOversight.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/StablePages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/language/QualityOversight.i18n.php
@@ -9,7 +9,7 @@
1010
1111 $messages['en'] = array(
1212 'qualityoversight' => 'Quality oversight',
13 - 'qualityoversight-list' => 'This page lists the most recent approvals and depreciations of revisions.',
 13+ 'qualityoversight-list' => 'This page lists the most recent approvals and deprecations of revisions.',
1414 'qualityoversight-legend' => 'Search recent review logs',
1515 );
1616
Index: trunk/extensions/FlaggedRevs/specialpages/StablePages_body.php
@@ -70,12 +70,17 @@
7171 }
7272 $stable = $this->skin->makeKnownLinkObj( $title, wfMsgHtml('stablepages-stable'), 'stable=1' );
7373
74 - if( intval($row->fpc_select) === FLAGGED_VIS_PRISTINE ) {
75 - $type = wfMsgHtml('stablepages-prec-pristine');
76 - } elseif( intval($row->fpc_select) === FLAGGED_VIS_QUALITY ) {
77 - $type = wfMsgHtml('stablepages-prec-quality');
78 - } else {
79 - $type = wfMsgHtml('stablepages-prec-none');
 74+ $type = '';
 75+ // Show precedence if there are several possible levels
 76+ if( FlaggedRevs::qualityVersions() ) {
 77+ if( intval($row->fpc_select) === FLAGGED_VIS_PRISTINE ) {
 78+ $type = wfMsgHtml('stablepages-prec-pristine');
 79+ } elseif( intval($row->fpc_select) === FLAGGED_VIS_QUALITY ) {
 80+ $type = wfMsgHtml('stablepages-prec-quality');
 81+ } else {
 82+ $type = wfMsgHtml('stablepages-prec-none');
 83+ }
 84+ $type = " (<b>{$type}</b>) ";
8085 }
8186
8287 if( $row->fpc_expiry != 'infinity' && strlen($row->fpc_expiry) ) {
@@ -89,7 +94,7 @@
9095 $expiry_description = "";
9196 }
9297
93 - return "<li>{$link} ({$config}) [{$stable}] (<b>{$type}</b>) <i>{$expiry_description}</i></li>";
 98+ return "<li>{$link} ({$config}) [{$stable}]{$type}<i>{$expiry_description}</i></li>";
9499 }
95100 }
96101

Status & tagging log