r60123 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60122‎ | r60123 | r60124 >
Date:14:50, 16 December 2009
Author:catrope
Status:deferred
Tags:
Comment:
UsabilityInitiative: Remove Safari newline handling fix introduced in r60098; it breaks other browsers (keeps moving the cursor to the beginning in Firefox) and will be unnecessary after the TOC header wrapping code has been rewritten
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toc.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toc.js
@@ -414,9 +414,8 @@
415415 outline[h] = { 'text': match[2], 'wrapper': div, 'level': match[1].length, 'index': h + 1 };
416416 h++;
417417 }
418 - context.$content.html( context.$content.html().replace( /\r?\n/g, "<br>" ) );
419418 context.$content.each( traverseTextNodes );
420 -
 419+
421420 // Normalize heading levels for list creation
422421 // This is based on Linker::generateTOC(), so it should behave like the
423422 // TOC on rendered articles does - which is considdered to be correct

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60098Fixing the NTOC buidling in Safari, and probably other webkit browsers. Fixin...adam23:09, 15 December 2009

Status & tagging log