r60051 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60050‎ | r60051 | r60052 >
Date:23:05, 14 December 2009
Author:demon
Status:ok
Tags:
Comment:
Update callers from immediateCommit() to commit(). The former's been deprecated a really long time...Tim did it 45243 revisions ago.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/ExternalStoreDB.php (modified) (history)
  • /trunk/phase3/includes/db/Database.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseMssql.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)
  • /trunk/phase3/includes/db/LoadBalancer.php (modified) (history)
  • /trunk/phase3/includes/filerepo/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1509,7 +1509,7 @@
15101510 if( $wgUseSquid ) {
15111511 // Commit the transaction before the purge is sent
15121512 $dbw = wfGetDB( DB_MASTER );
1513 - $dbw->immediateCommit();
 1513+ $dbw->commit();
15141514
15151515 // Send purge
15161516 $update = SquidUpdate::newSimplePurge( $this->mTitle );
Index: trunk/phase3/includes/db/DatabaseMysql.php
@@ -129,7 +129,7 @@
130130 $this->mOpened = false;
131131 if ( $this->mConn ) {
132132 if ( $this->trxLevel() ) {
133 - $this->immediateCommit();
 133+ $this->commit();
134134 }
135135 return mysql_close( $this->mConn );
136136 } else {
Index: trunk/phase3/includes/db/Database.php
@@ -1878,7 +1878,7 @@
18791879
18801880 # Commit any open transactions
18811881 if ( $this->mTrxLevel ) {
1882 - $this->immediateCommit();
 1882+ $this->commit();
18831883 }
18841884
18851885 if ( !is_null( $this->mFakeSlaveLag ) ) {
Index: trunk/phase3/includes/db/DatabaseMssql.php
@@ -131,7 +131,7 @@
132132 function close() {
133133 $this->mOpened = false;
134134 if ($this->mConn) {
135 - if ($this->trxLevel()) $this->immediateCommit();
 135+ if ($this->trxLevel()) $this->commit();
136136 return mssql_close($this->mConn);
137137 } else return true;
138138 }
Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -79,7 +79,7 @@
8080 function close() {
8181 $this->mOpened = false;
8282 if ( is_object( $this->mConn ) ) {
83 - if ( $this->trxLevel() ) $this->immediateCommit();
 83+ if ( $this->trxLevel() ) $this->commit();
8484 $this->mConn = null;
8585 }
8686 return true;
Index: trunk/phase3/includes/db/LoadBalancer.php
@@ -809,7 +809,7 @@
810810 foreach ( $this->mConns as $conns2 ) {
811811 foreach ( $conns2 as $conns3 ) {
812812 foreach ( $conns3 as $conn ) {
813 - $conn->immediateCommit();
 813+ $conn->commit();
814814 }
815815 }
816816 }
Index: trunk/phase3/includes/filerepo/LocalFile.php
@@ -937,7 +937,7 @@
938938
939939 # Commit the transaction now, in case something goes wrong later
940940 # The most important thing is that files don't get lost, especially archives
941 - $dbw->immediateCommit();
 941+ $dbw->commit();
942942
943943 # Invalidate cache for all pages using this file
944944 $update = new HTMLCacheUpdate( $this->getTitle(), 'imagelinks' );
Index: trunk/phase3/includes/ExternalStoreDB.php
@@ -140,7 +140,7 @@
141141 throw new MWException( __METHOD__.': no insert ID' );
142142 }
143143 if ( $dbw->getFlag( DBO_TRX ) ) {
144 - $dbw->immediateCommit();
 144+ $dbw->commit();
145145 }
146146 return "DB://$cluster/$id";
147147 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r60053Followup r60051, with the rest of the callers and removing a useless subclass...demon23:18, 14 December 2009

Status & tagging log