r60001 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60000‎ | r60001 | r60002 >
Date:18:38, 12 December 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Modified paths:
  • /trunk/extensions/SemanticMaps/FormInputs/SM_FormInputs.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/QueryPrinters/SM_QueryPrinters.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/FormInputs/SM_FormInputs.php
@@ -57,29 +57,26 @@
5858 self::$parameters = array(
5959 'centre' => array(
6060 'aliases' => array('center'),
61 - 'criteria' => array(),
6261 'default' => $egMapsDefaultCentre
6362 ),
6463 'service' => array(
65 - 'aliases' => array(),
6664 'criteria' => array(
6765 'in_array' => $egMapsAvailableServices
6866 ),
6967 'default' => $egMapsDefaultServices['fi']
7068 ),
7169 'geoservice' => array(
72 - 'aliases' => array(),
7370 'criteria' => array(
7471 'in_array' => array_keys($egMapsAvailableGeoServices)
7572 ),
7673 'default' => $egMapsDefaultGeoService
7774 ),
78 - 'service_name' => array('default' => ''),
79 - 'part_of_multiple' => array('default' => ''),
80 - 'possible_values' => array('default' => ''),
81 - 'is_list' => array('default' => ''),
82 - 'semantic_property' => array('default' => ''),
83 - 'value_labels' => array('default' => ''),
 75+ 'service_name' => array(),
 76+ 'part_of_multiple' => array(),
 77+ 'possible_values' => array(),
 78+ 'is_list' => array(),
 79+ 'semantic_property' => array(),
 80+ 'value_labels' => array(),
8481 );
8582 }
8683
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -25,7 +25,7 @@
2626
2727 // Only initialize the extension when all dependencies are present.
2828 if (defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' )) {
29 - define('SM_VERSION', '0.5 a20');
 29+ define('SM_VERSION', '0.5 a21');
3030
3131 $smgScriptPath = $wgScriptPath . '/extensions/SemanticMaps';
3232 $smgIP = $IP . '/extensions/SemanticMaps';
Index: trunk/extensions/SemanticMaps/QueryPrinters/SM_QueryPrinters.php
@@ -52,20 +52,16 @@
5353
5454 self::$parameters = array(
5555 'geoservice' => array(
56 - 'aliases' => array(),
5756 'criteria' => array(
5857 'in_array' => array_keys($egMapsAvailableGeoServices)
5958 ),
6059 'default' => $egMapsDefaultGeoService
6160 ),
6261 'format' => array(
63 - 'aliases' => array(),
64 - 'criteria' => array(),
6562 'default' => $egMapsDefaultServices['qp']
6663 ),
6764 'centre' => array(
6865 'aliases' => array('center'),
69 - 'criteria' => array(),
7066 'default' => $egMapsDefaultCentre
7167 ),
7268 );
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php
@@ -36,10 +36,11 @@
3737 'default' => '',
3838 ),
3939 'overlays' => array(
40 - 'aliases' => array(),
41 - 'criteria' => array(),
42 - 'default' => ''
43 - ),
 40+ 'type' => 'list-string',
 41+ 'criteria' => array(
 42+ 'all_in_array' => MapsGoogleMaps::getOverlayNames()
 43+ ),
 44+ ),
4445 );
4546 }
4647
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -31,15 +31,7 @@
3232
3333 $this->earthZoom = 1;
3434
35 - $this->defaultZoom = $egMapsGoogleMapsZoom;
36 -
37 - $this->spesificParameters = array(
38 - 'overlays' => array(
39 - 'aliases' => array(),
40 - 'criteria' => array(),
41 - 'default' => ''
42 - ),
43 - );
 35+ $this->defaultZoom = $egMapsGoogleMapsZoom;
4436 }
4537
4638 /**
@@ -86,6 +78,7 @@
8779
8880 $this->controls = MapsMapper::createJSItemsString(explode(',', $this->controls));
8981
 82+ // Remove the overlays control in case it's present.
9083 if (in_string('overlays', $this->controls)) {
9184 $this->controls = str_replace(",'overlays'", '', $this->controls);
9285 $this->controls = str_replace("'overlays',", '', $this->controls);

Status & tagging log