r59998 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59997‎ | r59998 | r59999 >
Date:17:32, 12 December 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Reduce lines on Special:Translate/manage
Modified paths:
  • /trunk/extensions/Translate/SpecialManageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/SpecialManageGroups.php
@@ -42,25 +42,27 @@
4343 $groups = MessageGroups::singleton()->getGroups();
4444
4545 $wgOut->wrapWikiMsg( '==$1==', 'translate-manage-listgroups' );
 46+ $separator = wfMsg( 'word-separator' );
4647
4748 foreach ( $groups as $group ) {
4849 if ( !$group instanceof FileBasedMessageGroup ) continue;
4950
5051 $link = $this->skin->link( $this->getTitle(), $group->getLabel(), array(), array( 'group' => $group->getId() ) );
51 - $wgOut->addHtml( $link );
 52+ $out = $link . $separator;
5253
5354 $cache = new MessageGroupCache( $group );
5455
5556 if ( $cache->exists() ) {
5657 $timestamp = wfTimestamp( TS_MW, $cache->getTimestamp() );
57 - $wgOut->addWikiMsg( 'translate-manage-cacheat',
 58+ $out .= wfMsg( 'translate-manage-cacheat',
5859 $wgLang->date( $timestamp ),
5960 $wgLang->time( $timestamp )
6061 );
6162 } else {
62 - $wgOut->addWikiMsg( 'translate-manage-newgroup' );
 63+ $$out .= wfMsg( 'translate-manage-newgroup' );
6364 }
6465
 66+ $wgOut->addHtml( $out );
6567 $wgOut->addHtml( '<hr>' );
6668 }
6769

Status & tagging log