r59977 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59976‎ | r59977 | r59978 >
Date:22:26, 11 December 2009
Author:dale
Status:deferred
Tags:
Comment:
* some timed text fixes
Modified paths:
  • /branches/js2-work/phase3/js2/mwEmbed/libEmbedPlayer/embedPlayer.js (modified) (history)
  • /branches/js2-work/phase3/js2/mwEmbed/libTimedText/mvTextInterface.js (modified) (history)
  • /branches/js2-work/phase3/js2/mwEmbed/mwEmbed.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js2/mwEmbed/libEmbedPlayer/embedPlayer.js
@@ -2033,7 +2033,7 @@
20342034 * @param {String} src New src of thumbnail
20352035 * @param {Boolean} quick_switch
20362036 * true switch happens instantly
2037 - * false / undefined annimated cross fade
 2037+ * false / undefined animated cross fade
20382038 */
20392039 updateThumbnail : function( src, quick_switch ) {
20402040 // make sure we don't go to the same url if we are not already updating:
@@ -2159,7 +2159,7 @@
21602160 /**
21612161 * Follows a linkback. Loads the ROE xml if no linkback is found
21622162 */
2163 - doLinkBack:function() {
 2163+ doLinkBack: function() {
21642164 if ( ! this.linkback && this.roe && this.media_element.addedROEData == false ) {
21652165 var _this = this;
21662166 this.displayOverlay( gM( 'mwe-loading_txt' ) );
@@ -2807,17 +2807,17 @@
28082808 /**
28092809 * Hides the playhead highlight
28102810 */
2811 - hideHighlight:function() {
 2811+ hideHighlight: function() {
28122812 var eid = ( this.pc ) ? this.pc.pp.id:this.id;
28132813 $j( '#mv_seeker_' + eid + ' .mv_highlight' ).hide();
2814 - this.setStatus( this.getTimeReq() );
2815 - thigetTimeRangerValue( 0 );
 2814+ this.setStatus( this.getTimeRange() );
28162815 },
28172816
28182817 /**
28192818 * Updates the player status that displays short text msgs and the play clock
 2819+ * @param {String} value Status string value to update
28202820 */
2821 - setStatus:function( value ) {
 2821+ setStatus: function( value ) {
28222822 var eid = ( this.pc ) ? this.pc.pp.id:this.id;
28232823 // update status:
28242824 $j( '#' + eid + ' .time-disp' ).html( value );
Index: branches/js2-work/phase3/js2/mwEmbed/mwEmbed.js
@@ -544,6 +544,7 @@
545545 }
546546 /**
547547 * parse template text as template name and named params
 548+ * @param {String} ts Template String to be parsed
548549 */
549550 function parseTmplTxt( ts ) {
550551 var tObj = { };
@@ -633,8 +634,9 @@
634635
635636 // do the recursive magic swap text:
636637 this.pOut = recurse_magic_swap( this.pNode );
637 - },
638 - /*
 638+ },
 639+
 640+ /**
639641 * parsed template api ~loosely based off of ~POM~
640642 * http://www.mediawiki.org/wiki/Extension:Page_Object_Model
641643 */
@@ -773,14 +775,13 @@
774776 *
775777 * {Array} {Array} Can be a set of Arrays for loading.
776778 * Some browsers execute included scripts out of order.
777 - * This lets you chain sets of request for those browers.
 779+ * This lets you chain sets of request for those browsers.
778780 * If using the script-loader order is preserved in output and
779781 * a single request will be used.
780782 *
781783 * @param {Function} callback Function called once loading is complete
782784 */
783785 load: function( loadRequest, callback ){
784 -
785786 // Check for empty loadRequest ( directly return the callback )
786787 if( $.isEmpty( loadRequest ) ){
787788 mw.log( 'Error: Empty load request ' );
Index: branches/js2-work/phase3/js2/mwEmbed/libTimedText/mvTextInterface.js
@@ -73,7 +73,7 @@
7474 'apprefix' : _this.pe.wikiTitleKey,
7575 'apnamespace' : timedtext_ns,
7676 'prop':'revisions'
77 - }'
 77+ };
7878 mw.getJSON( apiUrl, request, function( subData ) {
7979 if ( subData.error && subData.error.code == 'apunknown_apnamespace' ) {
8080 var request = {
@@ -350,7 +350,7 @@
351351 return '<div id="mmbody_' + this.pe.id + '" ' +
352352 'style="position:absolute;top:30px;left:0px;' +
353353 'right:0px;bottom:0px;' +
354 - 'height:' + ( this.pe.height - 30 ) +
 354+ 'height:' + ( this.pe.height) +
355355 'px;overflow:auto;"><span style="display:none;" id="mv_txt_load_' + this.pe.id + '">' +
356356 mw.loading_spiner() + '</span>' +
357357 '</div>';

Status & tagging log