r59964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59963‎ | r59964 | r59965 >
Date:19:43, 11 December 2009
Author:simetrical
Status:ok
Tags:
Comment:
Delete refs to variable removed in r59692
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -892,7 +892,6 @@
893893 public function getQueryInfo() {
894894 $tables = array( 'logging', 'user' );
895895 $this->mConds[] = 'user_id = log_user';
896 - $groupBy = false;
897896 $index = array();
898897 $options = array();
899898 # Add log_search table if there are conditions on it
@@ -916,7 +915,6 @@
917916 }
918917 $options['USE INDEX'] = $index;
919918 # Don't show duplicate rows when using log_search
920 - if( $groupBy ) $options['GROUP BY'] = $groupBy;
921919 $info = array(
922920 'tables' => $tables,
923921 'fields' => array( 'log_type', 'log_action', 'log_user', 'log_namespace',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59692(bug 20150): Change query to explicity select distinct rows instead of doing ...overlordq02:37, 3 December 2009

Status & tagging log