r59957 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59956‎ | r59957 | r59958 >
Date:18:10, 11 December 2009
Author:catrope
Status:ok
Tags:
Comment:
wmf-deployment: Merge r59944 (year-to-date field in fundraiser statistics) from trunk
Modified paths:
  • /branches/wmf-deployment/extensions/ContributionReporting (modified) (history)
  • /branches/wmf-deployment/extensions/ContributionReporting/ContributionReporting.i18n.php (modified) (history)
  • /branches/wmf-deployment/extensions/ContributionReporting/FundraiserStatistics_body.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/ContributionReporting/FundraiserStatistics_body.php
@@ -131,7 +131,9 @@
132132 Xml::element( 'td', $tdLabelAttributes, wfMsg( 'fundraiserstats-contributions' ) ) .
133133 Xml::element( 'td', $tdValueAttributes, $wgLang->formatNum( number_format( $day[2] ) ) ) .
134134 Xml::element( 'td', $tdLabelAttributes, wfMsg( 'fundraiserstats-avg' ) ) .
135 - Xml::element( 'td', $tdValueAttributes, $wgLang->formatNum( number_format( $day[3], 2 ) ) )
 135+ Xml::element( 'td', $tdValueAttributes, $wgLang->formatNum( number_format( $day[3], 2 ) ) ) .
 136+ Xml::element( 'td', $tdLabelAttributes, wfMsg( 'fundraiserstats-ytd' ) ) .
 137+ Xml::element( 'td', $tdValueAttributes, $wgLang->formatNum( number_format( $day[5], 2 ) ) )
136138 )
137139 )
138140 );
@@ -215,7 +217,9 @@
216218 )
217219 );
218220 $totals = array();
 221+ $ytd = 0;
219222 while ( $row = $dbr->fetchRow( $res ) ) {
 223+ $row[] = $ytd += $row[1];
220224 $totals[] = $row;
221225 }
222226 return $totals;
Index: branches/wmf-deployment/extensions/ContributionReporting/ContributionReporting.i18n.php
@@ -76,6 +76,7 @@
7777 'fundraiserstats-contributions' => 'Contributions',
7878 'fundraiserstats-total' => 'Total (USD)',
7979 'fundraiserstats-avg' => 'Average (USD)',
 80+ 'fundraiserstats-ytd' => 'YTD Total (USD)',
8081 // 'fundraiserstats-med' => 'Median (USD)',
8182 'fundraiserstats-max' => 'Maximum (USD)',
8283 'fundraiserstats-tab-totals' => 'Totals (USD)',
Property changes on: branches/wmf-deployment/extensions/ContributionReporting
___________________________________________________________________
Name: svn:mergeinfo
8384 - /branches/REL1_15/phase3/extensions/ContributionReporting:51646
/trunk/extensions/ContributionReporting:56151-57449,58684,58687-59049,59134-59163,59165-59752
/trunk/extensions/ContributionTracking:58684
/trunk/phase3/extensions/ContributionReporting:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57541,57916,58151,58219,58633,58816
8485 + /branches/REL1_15/phase3/extensions/ContributionReporting:51646
/trunk/extensions/ContributionReporting:56151-57449,58684,58687-59049,59134-59163,59165-59752,59944
/trunk/extensions/ContributionTracking:58684
/trunk/phase3/extensions/ContributionReporting:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57541,57916,58151,58219,58633,58816

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59944Added Year-to-date field.tparscal01:07, 11 December 2009

Status & tagging log