r59939 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59938‎ | r59939 | r59940 >
Date:00:02, 11 December 2009
Author:nimishg
Status:ok
Tags:
Comment:
added 'typeof' check, less ambiguous
Modified paths:
  • /trunk/phase3/skins/common/edit.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/edit.js
@@ -30,7 +30,7 @@
3131 image.onclick = function() {
3232 insertTags(item.tagOpen, item.tagClose, item.sampleText);
3333 //click tracking
34 - if ( ( $j != undefined ) && ( $j.trackAction != undefined ) ) {
 34+ if ( ( typeof $j != 'undefined' ) && ( typeof $j.trackAction != 'undefined' ) ) {
3535 $j.trackAction("oldedit." + item.speedTip.replace(/ /g, "-"));
3636 }
3737 return false;

Status & tagging log