r59887 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59886‎ | r59887 | r59888 >
Date:13:38, 9 December 2009
Author:werdna
Status:deferred
Tags:
Comment:
Merge r59885, r59886
Modified paths:
  • /branches/wmf-deployment/extensions/LiquidThreads_alpha (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads_alpha/classes/View.php (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads_alpha/jquery/js2.combined.js (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads_alpha/lqt.js (modified) (history)

Diff [purge]

Property changes on: branches/wmf-deployment/extensions/LiquidThreads_alpha/jquery/js2.combined.js
___________________________________________________________________
Name: svn:mergeinfo
11 - /trunk/extensions/LiquidThreads/jquery/js2.combined.js:57390,59879,59883
22 + /trunk/extensions/LiquidThreads/jquery/js2.combined.js:57390,59879,59883,59885-59886
Index: branches/wmf-deployment/extensions/LiquidThreads_alpha/classes/View.php
@@ -822,10 +822,8 @@
823823
824824 $basePath = "$wgScriptPath/extensions/$wgLiquidThreadsExtensionName";
825825
826 - if ( !$wgEnableJS2system ) {
827 - $wgOut->addScriptFile( "$basePath/jquery/js2.combined.js" );
828 - $wgOut->addExtensionStyle( "$basePath/jquery/jquery-ui-1.7.2.css" );
829 - }
 826+ $wgOut->addScriptFile( "$basePath/jquery/js2.combined.js" );
 827+ $wgOut->addExtensionStyle( "$basePath/jquery/jquery-ui-1.7.2.css" );
830828
831829 $wgOut->addScriptFile( "$basePath/jquery/jquery.autogrow.js" );
832830
Index: branches/wmf-deployment/extensions/LiquidThreads_alpha/lqt.js
@@ -28,6 +28,7 @@
2929
3030 var repliesElement = $j(container).contents().filter('.lqt-thread-replies');
3131 var replyDiv = repliesElement.contents().filter('.lqt-reply-form');
 32+ replyDiv = replyDiv.add( $j(container).contents().filter('.lqt-reply-form') );
3233 if (!replyDiv.length) {
3334 // Create a div for it
3435 replyDiv = $j('<div class="lqt-reply-form lqt-edit-form"/>');
@@ -46,6 +47,7 @@
4748
4849 repliesElement.find('.lqt-replies-finish').before( replyDiv );
4950 }
 51+ replyDiv.show();
5052
5153 replyDiv = replyDiv[0];
5254
Property changes on: branches/wmf-deployment/extensions/LiquidThreads_alpha
___________________________________________________________________
Name: svn:mergeinfo
5355 - /trunk/extensions/LiquidThreads:57390,58990-59196,59198-59661,59666-59743,59782-59877,59879,59883
5456 + /trunk/extensions/LiquidThreads:57390,58990-59196,59198-59661,59666-59743,59782-59877,59879,59883,59885-59886

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59885Remove JS2 conditional, since the variable does not exist anymorewerdna13:36, 9 December 2009
r59886Fix replying to top-level threads with no existing replieswerdna13:36, 9 December 2009

Status & tagging log