r59850 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59849‎ | r59850 | r59851 >
Date:21:19, 8 December 2009
Author:tparscal
Status:ok
Tags:
Comment:
Improves on r59843 by keeping the href information and using a click handler to disable links in preview.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.preview.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.preview.js
@@ -57,7 +57,7 @@
5858 context.$preview.find( '.wikiEditor-preview-loading' ).hide();
5959 context.$preview.find( '.wikiEditor-preview-contents' )
6060 .html( data.parse.text['*'] )
61 - .find( 'a:not([href^=#])' ).attr( 'href', '#' );
 61+ .find( 'a:not([href^=#])' ).click( function() { return false; } );
6262 },
6363 'json'
6464 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59843Made links in preview all link to # - to disable links.tparscal19:40, 8 December 2009

Status & tagging log