r59793 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59792‎ | r59793 | r59794 >
Date:19:01, 7 December 2009
Author:catrope
Status:ok
Tags:
Comment:
wmf-deployment: Disable ClickTracking for left nav and old toolbar: we've got enough data and it's apparently causing slowness
Modified paths:
  • /branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking/ClickTracking.js (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking/ClickTracking.php (modified) (history)
  • /branches/wmf-deployment/includes/DefaultSettings.php (modified) (history)
  • /branches/wmf-deployment/skins/common/edit.js (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/skins/common/edit.js
@@ -29,10 +29,6 @@
3030 image.style.cursor = "pointer";
3131 image.onclick = function() {
3232 insertTags(item.tagOpen, item.tagClose, item.sampleText);
33 - //click tracking
34 - if ( ( $j != undefined ) && ( $j.trackAction != undefined ) ) {
35 - $j.trackAction("oldedit." + item.speedTip.replace(/ /g, "-"));
36 - }
3733 return false;
3834 };
3935
Property changes on: branches/wmf-deployment/skins/common/edit.js
___________________________________________________________________
Name: svn:mergeinfo
4036 - /branches/REL1_15/phase3/skins/common/edit.js:51646
/trunk/phase3/skins/common/edit.js:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447,57541,57916,58151,58219,58633,58816,59604
4137 +
Index: branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking/ClickTracking.js
@@ -4,23 +4,6 @@
55 $.trackAction = function ( id ) {
66 $j.post( wgScriptPath + '/api.php', { 'action': 'clicktracking', 'eventid': id, 'token': wgTrackingToken } );
77 };
8 -
9 - // Clicktrack the left sidebar links
10 - $(document).ready( function() {
11 - $( '#p-logo a, #p-navigation a, #p-tb a' ).click( function() {
12 - var id = 'leftnav-' + skin + '-' +
13 - ( $(this).attr( 'id' ) || $(this).parent().attr( 'id' ) );
14 - var href = $(this).attr( 'href' );
15 - // Don't attach to javascript: URLs and the like,
16 - // only to local URLs (start with a /), http:// ,
17 - // https:// and same-protocol URLs (start with //)
18 - if ( href[0] == '/' || href.match( /^https?:\/\// ) )
19 - window.location = wgScriptPath +
20 - '/api.php?action=clicktracking&eventid=' +
21 - id + '&token=' + wgTrackingToken +
22 - '&redirectto=' + escape( href );
23 - });
24 - });
258 }
269
27 -})(jQuery);
\ No newline at end of file
 10+})(jQuery);
Index: branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking/ClickTracking.php
@@ -19,7 +19,7 @@
2020 /* Configuration */
2121
2222 // Increment this value when you change ClickTracking.js
23 -$wgClickTrackingStyleVersion = 3;
 23+$wgClickTrackingStyleVersion = 4;
2424
2525 // click throttle, should be seen as "1 out of every $wgClickTrackThrottle users will have it enabled"
2626 // setting this to 1 means all users will have it enabled
@@ -66,4 +66,4 @@
6767
6868 // Adds Internationalized Messages
6969 $wgExtensionMessagesFiles['ClickTracking'] = $dir . 'ClickTracking.i18n.php';
70 -$wgExtensionAliasesFiles['ClickTracking'] = $dir . 'ClickTracking.alias.php';
\ No newline at end of file
 70+$wgExtensionAliasesFiles['ClickTracking'] = $dir . 'ClickTracking.alias.php';
Index: branches/wmf-deployment/includes/DefaultSettings.php
@@ -1605,7 +1605,7 @@
16061606 * to ensure that client-side caches do not keep obsolete copies of global
16071607 * styles.
16081608 */
1609 -$wgStyleVersion = '254';
 1609+$wgStyleVersion = '248';
16101610
16111611
16121612 # Server-side caching:
Property changes on: branches/wmf-deployment/includes/DefaultSettings.php
___________________________________________________________________
Name: svn:mergeinfo
16131613 - /branches/REL1_15/phase3/includes/DefaultSettings.php:51646
/branches/wmf-deployment/includes/DefaultSettings.php:53381
/trunk/phase3/includes/DefaultSettings.php:56213,56215-56216,56218,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447,57530,57541,57602,57916,58151,58219,58633,58816,59607
16141614 +

Status & tagging log