r59766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59765‎ | r59766 | r59767 >
Date:13:18, 6 December 2009
Author:overlordq
Status:ok
Tags:
Comment:
Fix 'performance' query conditions to actually work instead of always equal -20000
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -685,7 +685,7 @@
686686 'cp_repo_id' => $this->mRepoId,
687687 'cp_path LIKE ' . $dbr->addQuotes( $dbr->escapeLike( $path ) . '%' ),
688688 // performance
689 - 'cp_rev_id > ' . $this->mRepo->getLastStoredRev() - 20000,
 689+ 'cp_rev_id > ' . ( $this->mRepo->getLastStoredRev() - 20000 ),
690690 // join conds
691691 'cr_repo_id = cp_repo_id',
692692 'cr_id = cp_rev_id'
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -173,7 +173,7 @@
174174 'cp_repo_id' => $this->mRepo->getId(),
175175 'cp_path LIKE ' . $this->mDb->addQuotes( $this->mDb->escapeLike( $this->getSVNPath() ) . '%' ),
176176 // performance
177 - 'cp_rev_id > ' . $this->mRepo->getLastStoredRev() - 20000
 177+ 'cp_rev_id > ' . ( $this->mRepo->getLastStoredRev() - 20000 )
178178 ),
179179 'options' => array( 'GROUP BY' => 'cp_rev_id', 'USE INDEX' => array( 'code_path' => 'cp_repo_id' ) ),
180180 'join_conds' => array(

Status & tagging log