r59736 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59735‎ | r59736 | r59737 >
Date:15:49, 4 December 2009
Author:demon
Status:ok
Tags:
Comment:
Followup r59731: Make it opt-out instead of opt-in
Modified paths:
  • /trunk/phase3/maintenance/syntaxChecker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/syntaxChecker.php
@@ -35,7 +35,7 @@
3636 false, true);
3737 $this->addOption( 'list-file', 'Text file containing list of files or directories to check', false, true);
3838 $this->addOption( 'modified', 'Check only files that were modified (requires SVN command-line client)' );
39 - $this->addOption( 'code-style', 'Check for code style fixes too, not just syntax validity' );
 39+ $this->addOption( 'syntax-only', 'Check for syntax validity only, skip code style warnings' );
4040 }
4141
4242 protected function getDbType() {
@@ -55,7 +55,7 @@
5656 } else {
5757 $this->checkFileWithCli( $f );
5858 }
59 - if( $this->hasOption( 'code-style' ) ) {
 59+ if( !$this->hasOption( 'syntax-only' ) ) {
6060 $this->checkForMistakes( $f );
6161 }
6262 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59731Put an option on checking for non-syntax errorsdemon14:38, 4 December 2009

Status & tagging log