r59725 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59724‎ | r59725 | r59726 >
Date:09:34, 4 December 2009
Author:siebrand
Status:ok
Tags:
Comment:
Add separate message for special page title, as 'blockip' is also used in the tools portlet on user pages.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1895,6 +1895,7 @@
18961896 ),
18971897 'block' => array(
18981898 'blockip',
 1899+ 'blockip-title',
18991900 'blockip-legend',
19001901 'blockiptext',
19011902 'ipaddress',
Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -82,7 +82,7 @@
8383 public function showForm( $err ) {
8484 global $wgOut, $wgUser, $wgSysopUserBans;
8585
86 - $wgOut->setPageTitle( wfMsg( 'blockip' ) );
 86+ $wgOut->setPageTitle( wfMsg( 'blockip-title' ) );
8787 $wgOut->addWikiMsg( 'blockiptext' );
8888
8989 if( $wgSysopUserBans ) {
@@ -609,7 +609,7 @@
610610 public function showSuccess() {
611611 global $wgOut;
612612
613 - $wgOut->setPageTitle( wfMsg( 'blockip' ) );
 613+ $wgOut->setPageTitle( wfMsg( 'blockip-title' ) );
614614 $wgOut->setSubtitle( wfMsg( 'blockipsuccesssub' ) );
615615 $text = wfMsgExt( 'blockipsuccesstext', array( 'parse' ), $this->BlockAddress );
616616 $wgOut->addHTML( $text );
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2849,6 +2849,7 @@
28502850
28512851 # Block/unblock
28522852 'blockip' => 'Block user',
 2853+'blockip-title' => 'Block user',
28532854 'blockip-legend' => 'Block user',
28542855 'blockiptext' => 'Use the form below to block write access from a specific IP address or username.
28552856 This should be done only to prevent vandalism, and in accordance with [[{{MediaWiki:Policy-url}}|policy]].

Status & tagging log