r59698 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59697‎ | r59698 | r59699 >
Date:10:29, 3 December 2009
Author:dantman
Status:ok
Tags:
Comment:
Expand a few comments. One as per Nikerabbit's comment on r59695.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1536,7 +1536,7 @@
15371537 'tabindex' => '1',
15381538 'size' => 60,
15391539 'spellcheck' => 'true',
1540 - 'onfocus' => "currentFocused = this;",
 1540+ 'onfocus' => "currentFocused = this;", // Make wpSummary insertable for editbuttons
15411541 );
15421542 if ( $userInputAttrs )
15431543 $inputAttrs += $userInputAttrs;
@@ -1710,8 +1710,8 @@
17111711 'id' => $name,
17121712 'cols' => $wgUser->getIntOption( 'cols' ),
17131713 'rows' => $wgUser->getIntOption( 'rows' ),
1714 - 'onfocus' => "currentFocused = this;",
1715 - 'style' => '' // for php notices
 1714+ 'onfocus' => "currentFocused = this;", // Make textareas insertable for editbuttons
 1715+ 'style' => '' // avoid php notices when appending for editwidth preference (appending allows customAttribs['style'] to still work
17161716 );
17171717
17181718 if ( $wgUser->getOption( 'editwidth' ) )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59695Fix noticesdantman08:15, 3 December 2009

Status & tagging log