r59615 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59614‎ | r59615 | r59616 >
Date:02:52, 1 December 2009
Author:tomasz
Status:ok
Tags:
Comment:
Adding rewording for pending trxn's
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -674,6 +674,8 @@
675675 $this->fnPayflowDisplayDeclinedResults( $responseMsg );
676676 } elseif( ( $errorCode == '4' ) ) {
677677 $this->fnPayflowDisplayOtherResults( $responseMsg );
 678+ } elseif( ( $errorCode == '5' ) ) {
 679+ $this->fnPayflowDisplayPending( $responseMsg );
678680 }
679681
680682 }// end display results
@@ -696,7 +698,7 @@
697699 break;
698700 case '126':
699701 $responseMsg = wfMsg( 'payflowpro_gateway-response-126' );
700 - $errorCode = '1';
 702+ $errorCode = '5';
701703 break;
702704 case '12':
703705 $responseMsg = wfMsg( 'payflowpro_gateway-response-12' );
@@ -822,6 +824,13 @@
823825 // display response message
824826 $wgOut->addHTML( '<h3 class="response_message">' . $declinedDefault . $responseMsg . '</h3>' );
825827 }
 828+
 829+ function fnPayflowDisplayPending( $responseMsg ) {
 830+ global $wgOut;
 831+
 832+ // display response message
 833+ $wgOut->addHTML( '<h3 class="response_message">' . $responseMsg . '</h3>' );
 834+ }
826835
827836 function fnPayflowSaveContributionTracking( &$data ) {
828837 $data['optout'] = ($data['optout'] == "1") ? '0' : '1';
@@ -854,7 +863,7 @@
855864
856865 // Store the contribution data
857866 if ($db->insert( 'contribution_tracking', $tracked_contribution ) ) {
858 - $data['contribution_tracking_id'] = $db->insertId();
 867+ // $data['contribution_tracking_id'] = $db->insertId();
859868 return true;
860869 } else { return false; }
861870
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php
@@ -66,6 +66,7 @@
6767 'payflowpro_gateway-response-0' => 'Your transaction has been approved.
6868 Thank you for your donation!',
6969 'payflowpro_gateway-response-126' => 'Your transaction is pending approval.',
 70+ 'payflowpro_gateway-response-126-2' => 'Some of the information you provided did not match your credit card profile. For your own security, your donation is currently under review, and we will notify you through the provided e-mail address if we cannot finalize your donation. Please e-mail <a href="mailto:donate@wikimedia.org">donate@wikimedia.org</a> if you have any questions. Thank you!',
7071 'payflowpro_gateway-response-12' => 'Please contact your credit card company for further information.',
7172 'payflowpro_gateway-response-13' => 'Your transaction requires voice authorization.
7273 Please contact us to continue your transaction.', // This will not apply to Wikimedia accounts
@@ -78,6 +79,7 @@
7980 'payflowpro_gateway-response-default' => 'There was an error processing your transaction.
8081 Please try again later.',
8182 'php-response-declined' => 'Your transaction has been declined.',
 83+ 'payflowpro_gateway-thankyou' => 'Thank you for your donation!',
8284 'payflowpro_gateway-post-transaction' => 'Transaction details',
8385 'payflowpro_gateway-submit-button' => 'Donate',
8486 'payflowpro_gateway-cvv-explain' => '<h4>What is CVV?</h4>

Status & tagging log