r5960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r5959‎ | r5960 | r5961 >
Date:04:23, 18 October 2004
Author:wmahan
Status:old
Tags:
Comment:
Bug 506: use $_SERVER[] instead of getenv() because the latter
doesn't work on IIS in ISAPI mode.
Modified paths:
  • /branches/REL1_3/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_3/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/REL1_3/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: branches/REL1_3/phase3/includes/DefaultSettings.php
@@ -47,8 +47,8 @@
4848 $wgMathPath = "{$wgUploadPath}/math";
4949 $wgMathDirectory = "{$wgUploadDirectory}/math";
5050 $wgTmpDirectory = "{$wgUploadDirectory}/tmp";
51 -$wgEmergencyContact = 'wikiadmin@' . getenv( 'SERVER_NAME' );
52 -$wgPasswordSender = 'Wikipedia Mail <apache@' . getenv( 'SERVER_NAME' ) . '>';
 51+$wgEmergencyContact = 'wikiadmin@' . $_SERVER['SERVER_NAME'];
 52+$wgPasswordSender = 'Wikipedia Mail <apache@' . $_SERVER['SERVER_NAME'] . '>';
5353
5454 # For using a direct (authenticated) SMTP server connection.
5555 # "host" => 'SMTP domain', "IDHost" => 'domain for MessageID', "port" => "25", "auth" => true/false, "username" => user, "password" => password
Index: branches/REL1_3/phase3/includes/Setup.php
@@ -32,7 +32,7 @@
3333 }
3434 $wgIP = trim(end($hopips));
3535 } else {
36 - $wgIP = getenv('REMOTE_ADDR');
 36+ $wgIP = $_SERVER['REMOTE_ADDR'];
3737 }
3838
3939
Index: branches/REL1_3/phase3/RELEASE-NOTES
@@ -3,6 +3,10 @@
44 Security reminder: MediaWiki does not require PHP's register_globals
55 setting since version 1.2.0. If you have it on, turn it *off* if you can.
66
 7+== Version 1.3.8, 2004-10-?? ==
 8+Changes from 1.3.7:
 9+* (bug 506) fix array_key_exists() warning for IIS servers using
 10+ ISAPI mode
711
812 == Version 1.3.7, 2004-10-18 ==
913 Changes from 1.3.6:

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r5336Bug 506: use $_SERVER[] instead of getenv() because the latter doesn't work...wmahan21:53, 20 September 2004

Status & tagging log