r5955 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r5954‎ | r5955 | r5956 >
Date:00:09, 18 October 2004
Author:kateturner
Status:old
Tags:
Comment:
security fix
Modified paths:
  • /branches/REL1_3/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_3/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: branches/REL1_3/phase3/includes/Title.php
@@ -515,7 +515,7 @@
516516 if( Namespace::getUser() == $this->mNamespace
517517 and preg_match("/\\.(css|js)$/", $this->mTextform )
518518 and !$wgUser->isSysop()
519 - and !preg_match("/^".preg_quote($wgUser->getName(), '/')."/", $this->mTextform) )
 519+ and !preg_match("/^".preg_quote($wgUser->getName(), '/')."\//", $this->mTextform) )
520520 { return false; }
521521 $ur = $wgUser->getRights();
522522 foreach ( $this->getRestrictions() as $r ) {
@@ -556,7 +556,7 @@
557557 # protect css/js subpages of user pages
558558 # XXX: this might be better using restrictions
559559 global $wgUser;
560 - return ( $wgUser->isSysop() or preg_match("/^".preg_quote($wgUser->getName())."/", $this->mTextform) );
 560+ return ( $wgUser->isSysop() or preg_match("/^".preg_quote($wgUser->getName(), '/')."\//", $this->mTextform) );
561561 }
562562
563563 # Accessor/initialisation for mRestrictions
Index: branches/REL1_3/phase3/RELEASE-NOTES
@@ -4,6 +4,10 @@
55 setting since version 1.2.0. If you have it on, turn it *off* if you can.
66
77
 8+== Version 1.3.7, 2004-10-18 ==
 9+Changes from 1.3.6:
 10+* Fix protected-page related security issue.
 11+
812 == Version 1.3.6, 2004-10-14 ==
913
1014 Changes from 1.3.5:

Status & tagging log