r59545 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59544‎ | r59545 | r59546 >
Date:15:10, 29 November 2009
Author:ialex
Status:ok
Tags:
Comment:
* (bug 21679) "Edit block reasons" link at the bottom of Special:Blockip is now only displayed to the users that have "editinterface" right
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -696,13 +696,15 @@
697697 $links[] = $this->getContribsLink( $skin );
698698 $links[] = $this->getUnblockLink( $skin );
699699 $links[] = $this->getBlockListLink( $skin );
700 - $title = Title::makeTitle( NS_MEDIAWIKI, 'Ipbreason-dropdown' );
701 - $links[] = $skin->link(
702 - $title,
703 - wfMsgHtml( 'ipb-edit-dropdown' ),
704 - array(),
705 - array( 'action' => 'edit' )
706 - );
 700+ if ( $wgUser->isAllowed( 'editinterface' ) ) {
 701+ $title = Title::makeTitle( NS_MEDIAWIKI, 'Ipbreason-dropdown' );
 702+ $links[] = $skin->link(
 703+ $title,
 704+ wfMsgHtml( 'ipb-edit-dropdown' ),
 705+ array(),
 706+ array( 'action' => 'edit' )
 707+ );
 708+ }
707709 return '<p class="mw-ipb-conveniencelinks">' . $wgLang->pipeList( $links ) . '</p>';
708710 }
709711
Index: trunk/phase3/RELEASE-NOTES
@@ -650,6 +650,8 @@
651651 PHP's memcached extension
652652 * (bug 21650) Both calls to SkinTemplateTabs hook are now compatible
653653 * (bug 21672) Add missing Accept-Language to both Vary and XVO headers
 654+* (bug 21679) "Edit block reasons" link at the bottom of Special:Blockip is now
 655+ only displayed to the users that have "editinterface" right
654656
655657 == API changes in 1.16 ==
656658

Status & tagging log