r59471 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59470‎ | r59471 | r59472 >
Date:21:00, 26 November 2009
Author:ialex
Status:ok
Tags:
Comment:
Follow-up r9468: fix functions called by SkinTemplateTabs hook to not break on PHP 5.3
Modified paths:
  • /trunk/extensions/EmailPage/EmailPage.php (modified) (history)
  • /trunk/extensions/GroupPermissionsManager/plugins/CustomTabs.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)
  • /trunk/extensions/Tasks/Tasks.php (modified) (history)
  • /trunk/extensions/Todo/SpecialTodo.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Tasks/Tasks.php
@@ -415,7 +415,7 @@
416416 * @param array $content_actions
417417 * @return bool true to continue running other hooks, false to abort operation
418418 */
419 -function wfTasksExtensionTab( &$skin, &$content_actions ) { # Checked for HTML and MySQL insertion attacks
 419+function wfTasksExtensionTab( $skin, &$content_actions ) { # Checked for HTML and MySQL insertion attacks
420420 global $wgTitle, $action;
421421 if( $wgTitle->isTalkPage() ) {
422422 # No talk pages please
Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -92,7 +92,7 @@
9393 /**
9494 * Add action link
9595 */
96 - function onSkinTemplateTabs( &$skin, &$actions ) {
 96+ function onSkinTemplateTabs( $skin, &$actions ) {
9797 $tmp = array();
9898 foreach ( $actions as $k => $v ) {
9999 $tmp[$k] = $v;
Index: trunk/extensions/EmailPage/EmailPage.php
@@ -60,7 +60,7 @@
6161 return true;
6262 }
6363
64 -function wfEmailPageActionLink( &$skin, &$actions ) {
 64+function wfEmailPageActionLink( $skin, &$actions ) {
6565 global $wgTitle, $wgUser, $wgEmailPageGroup;
6666 if ( is_object( $wgTitle ) && ( empty( $wgEmailPageGroup ) || in_array( $wgEmailPageGroup, $wgUser->getEffectiveGroups() ) ) ) {
6767 $url = Title::makeTitle( NS_SPECIAL, 'EmailPage' )->getLocalURL('ea-title='.$wgTitle->getPrefixedText() );
Index: trunk/extensions/Todo/SpecialTodo.php
@@ -55,7 +55,7 @@
5656 * @param array $actions
5757 * @return bool true to continue running hooks, false to abort operation
5858 */
59 -function todoAddTab( &$skin, &$actions ) {
 59+function todoAddTab( $skin, &$actions ) {
6060 global $wgTitle;
6161 if ( $wgTitle->getNamespace() == NS_USER || $wgTitle->getNamespace() == NS_USER_TALK ) {
6262 $title = Title::makeTitle( NS_SPECIAL, 'Todo/' . $wgTitle->getText() );
Index: trunk/extensions/GroupPermissionsManager/plugins/CustomTabs.php
@@ -154,7 +154,7 @@
155155 return $res; //if one of the extensions returned false, then we return false
156156 }
157157
158 -function efGPManagerGetSkin(&$skin, $ca) {
 158+function efGPManagerGetSkin($skin, $ca) {
159159 global $egSkinObj;
160160 $egSkinObj = $skin;
161161 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r9468Code cleanup: initialize the array variable rather than covering up an uninit...vibber09:55, 18 June 2005

Status & tagging log