r59467 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59466‎ | r59467 | r59468 >
Date:20:13, 26 November 2009
Author:juliano
Status:deferred
Tags:
Comment:
* Fix pass-by-reference call on SkinTemplateTabs hook.
* Fix pass-by-reference call on EditPage::importFormData hook.
* Shut up E_STRICT warnings about timezone. Same fix found in OutputPage::checkLastModified().
Modified paths:
  • /trunk/extensions/Wikilog/Wikilog.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogHooks.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogParser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikilog/Wikilog.php
@@ -331,7 +331,7 @@
332332 * Adds a wikilog tab to articles in Wikilog namespaces.
333333 * Suppresses the "add section" tab in comments pages.
334334 */
335 - static function SkinTemplateTabs( &$skin, &$contentActions ) {
 335+ static function SkinTemplateTabs( $skin, &$contentActions ) {
336336 global $wgRequest, $wgWikilogEnableComments;
337337
338338 $wi = self::getWikilogInfo( $skin->mTitle );
Index: trunk/extensions/Wikilog/WikilogHooks.php
@@ -322,7 +322,7 @@
323323 * Import wikilog article options form data in edit pages.
324324 * @note Requires MediaWiki 1.16+.
325325 */
326 - static function EditPageImportFormData( &$editpage, &$request ) {
 326+ static function EditPageImportFormData( $editpage, $request ) {
327327 if ( $request->wasPosted() ) {
328328 $editpage->wlSignpub = $request->getCheck( 'wlSignpub' );
329329 }
Index: trunk/extensions/Wikilog/WikilogParser.php
@@ -221,7 +221,9 @@
222222
223223 # First argument is the publish date
224224 if ( !is_null( $pubdate ) ) {
 225+ wfSuppressWarnings(); // Shut up E_STRICT warnings about timezone.
225226 $ts = strtotime( $pubdate );
 227+ wfRestoreWarnings();
226228 if ( $ts > 0 ) {
227229 $parser->mExtWikilog->mPubDate = wfTimestamp( TS_MW, $ts );
228230 }

Status & tagging log