r59452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59451‎ | r59452 | r59453 >
Date:15:20, 26 November 2009
Author:mkroetzsch
Status:deferred
Tags:
Comment:
allow cloumns parameter not just for ul and ol, there are useful applications for this, even if it does not look good with standard lists
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php
@@ -36,11 +36,9 @@
3737 $this->mUserParam = trim($params['userparam']);
3838 }
3939 if (array_key_exists('columns', $params)) {
40 - if ( ('ul' == $this->mFormat) || ('ol' == $this->mFormat) ) {
41 - $columns = trim($params['columns']);
42 - // allow a maximum of 10 columns
43 - if ($columns > 1 && $columns <= 10)
44 - $this->mColumns = (int)$columns;
 40+ $columns = trim($params['columns']);
 41+ if ($columns > 1 && $columns <= 10) { // allow a maximum of 10 columns
 42+ $this->mColumns = (int)$columns;
4543 }
4644 }
4745 }

Status & tagging log