r59316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59315‎ | r59316 | r59317 >
Date:15:10, 21 November 2009
Author:catrope
Status:deferred
Tags:
Comment:
UsabilityInitiative: Whitespaces fixes for TOC CSS
Modified paths:
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.toc.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.toc.css
@@ -45,11 +45,11 @@
4646 line-height: 26px;
4747 padding-left: 1em;
4848 border-bottom: solid 1px silver;
49 - white-space:nowrap;
50 - overflow:hidden;
 49+ white-space: nowrap;
 50+ overflow: hidden;
5151 }
52 -.tab-toc a{
53 - outline:none;
 52+.tab-toc a {
 53+ outline: none;
5454 }
5555 .wikiEditor-ui-toc li {
5656 padding: 0;
@@ -100,82 +100,84 @@
101101 /* Collapsing changes */
102102
103103 .wikiEditor-ui-toc {
104 - overflow-y:hidden;
105 - position:relative;
 104+ overflow-y: hidden;
 105+ position: relative;
106106 }
107107 .wikiEditor-ui-toc ul {
108 - overflow-y:auto;
109 - overflow-x:hidden;
110 - height:100%;
111 - margin-bottom:0 !important;
 108+ overflow-y: auto;
 109+ overflow-x: hidden;
 110+ height: 100%;
 111+ margin-bottom: 0 !important;
112112
113113 }
114114
115115 .wikiEditor-ui-toc ul ul {
116 - float:none;
117 - height:auto;
 116+ float: none;
 117+ height: auto;
118118 }
119119 #wikiEditor-ui-toc-collapse {
120 - height:100%;
121 - width:18px;
122 - position:absolute;
123 - top:0;
124 - left:0;
 120+ height: 100%;
 121+ width: 18px;
 122+ position: absolute;
 123+ top: 0;
 124+ left: 0;
125125 }
126126 .wikiEditor-ui-toc-collapse-open {
127 - background:#f3f3f3 url(../images/wikiEditor/toc/close.png) 4px 50% no-repeat;
128 - border-left:1px solid #DDDDDD;
 127+ background: #f3f3f3 url(../images/wikiEditor/toc/close.png) 4px 50% no-repeat;
 128+ border-left: 1px solid #DDDDDD;
129129 }
130130 .wikiEditor-ui-toc-collapse-closed {
131 - background:#f3f3f3 url(../images/wikiEditor/toc/open.png) 4px 50% no-repeat;
 131+ background: #f3f3f3 url(../images/wikiEditor/toc/open.png) 4px 50% no-repeat;
132132 }
133133
134134 /* Resizing Changes */
135135 .wikiEditor-ui-toc-resize-vertical,
136 -.ui-resizable-w{
137 - width:4px;
138 - position:absolute;
139 - top:0;
140 - left:0;
141 - height:100%;
142 - cursor:ew-resize;
 136+.ui-resizable-w {
 137+ width: 4px;
 138+ position: absolute;
 139+ top: 0;
 140+ left: 0;
 141+ height: 100%;
 142+ cursor: ew-resize;
143143 }
144144 .wikiEditor-ui .wikiEditor-ui-right {
145 - overflow:visible;
 145+ overflow: visible;
146146 }
147 -.wikiEditor-ui-right .ui-resizable-w{
 147+.wikiEditor-ui-right .ui-resizable-w {
148148 left: 0px !important;
149149 }
150150
151 -.wikiEditor-ui-right .wikiEditor-ui-toc-resize-grip{
152 - width:5px;
153 - height:12px;
154 - padding:3px;
155 - position:absolute;
156 - top:7px;
157 - left:-12px !important;
158 - cursor:ew-resize;
159 - background:url(../images/wikiEditor/toc/grip.png) 50% 50% no-repeat;
 151+.wikiEditor-ui-right .wikiEditor-ui-toc-resize-grip {
 152+ width: 5px;
 153+ height: 12px;
 154+ padding: 3px;
 155+ position: absolute;
 156+ top: 7px;
 157+ left: -12px !important;
 158+ cursor: ew-resize;
 159+ background: url(../images/wikiEditor/toc/grip.png) 50% 50% no-repeat;
160160 }
161 -.wikiEditor-ui-toolbar .tab-toc{
162 - float:right;
163 - margin:3px 16px 3px 3px;
164 - line-height:26px;
 161+.wikiEditor-ui-toolbar .tab-toc {
 162+ float: right;
 163+ margin: 3px 16px 3px 3px;
 164+ line-height: 26px;
165165 }
166 -.wikiEditor-ui-toc-expandControl{
 166+.wikiEditor-ui-toc-expandControl {
167167 position: absolute;
168 - z-index:2;
169 - top:0px;
170 - right:10px;
 168+ z-index: 2;
 169+ top: 0px;
 170+ right: 10px;
171171 height: 26px;
172172 padding: 3px 0;
173173 line-height: 26px;
174174 padding-right: 1em;
175 - white-space:nowrap;
176 - overflow:hidden;
 175+ white-space: nowrap;
 176+ overflow: hidden;
177177 }
178 -.wikiEditor-ui-text textarea{
179 - resize:none;
 178+.wikiEditor-ui-text textarea {
 179+ resize: none;
180180 }
181 -.wikiEditor-ui-text textarea:focus {outline:none;}
 181+.wikiEditor-ui-text textarea:focus {
 182+ outline: none;
 183+}
182184
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -175,11 +175,11 @@
176176 line-height: 26px;
177177 padding-left: 1em;
178178 border-bottom: solid 1px silver;
179 - white-space:nowrap;
180 - overflow:hidden;
 179+ white-space: nowrap;
 180+ overflow: hidden;
181181 }
182 -.tab-toc a{
183 - outline:none;
 182+.tab-toc a {
 183+ outline: none;
184184 }
185185 .wikiEditor-ui-toc li {
186186 padding: 0;
@@ -230,84 +230,86 @@
231231 /* Collapsing changes */
232232
233233 .wikiEditor-ui-toc {
234 - overflow-y:hidden;
235 - position:relative;
 234+ overflow-y: hidden;
 235+ position: relative;
236236 }
237237 .wikiEditor-ui-toc ul {
238 - overflow-y:auto;
239 - overflow-x:hidden;
240 - height:100%;
241 - margin-bottom:0 !important;
 238+ overflow-y: auto;
 239+ overflow-x: hidden;
 240+ height: 100%;
 241+ margin-bottom: 0 !important;
242242
243243 }
244244
245245 .wikiEditor-ui-toc ul ul {
246 - float:none;
247 - height:auto;
 246+ float: none;
 247+ height: auto;
248248 }
249249 #wikiEditor-ui-toc-collapse {
250 - height:100%;
251 - width:18px;
252 - position:absolute;
253 - top:0;
254 - left:0;
 250+ height: 100%;
 251+ width: 18px;
 252+ position: absolute;
 253+ top: 0;
 254+ left: 0;
255255 }
256256 .wikiEditor-ui-toc-collapse-open {
257 - background:#f3f3f3 url(../images/wikiEditor/toc/close.png) 4px 50% no-repeat;
258 - border-left:1px solid #DDDDDD;
 257+ background: #f3f3f3 url(../images/wikiEditor/toc/close.png) 4px 50% no-repeat;
 258+ border-left: 1px solid #DDDDDD;
259259 }
260260 .wikiEditor-ui-toc-collapse-closed {
261 - background:#f3f3f3 url(../images/wikiEditor/toc/open.png) 4px 50% no-repeat;
 261+ background: #f3f3f3 url(../images/wikiEditor/toc/open.png) 4px 50% no-repeat;
262262 }
263263
264264 /* Resizing Changes */
265265 .wikiEditor-ui-toc-resize-vertical,
266 -.ui-resizable-w{
267 - width:4px;
268 - position:absolute;
269 - top:0;
270 - left:0;
271 - height:100%;
272 - cursor:ew-resize;
 266+.ui-resizable-w {
 267+ width: 4px;
 268+ position: absolute;
 269+ top: 0;
 270+ left: 0;
 271+ height: 100%;
 272+ cursor: ew-resize;
273273 }
274274 .wikiEditor-ui .wikiEditor-ui-right {
275 - overflow:visible;
 275+ overflow: visible;
276276 }
277 -.wikiEditor-ui-right .ui-resizable-w{
 277+.wikiEditor-ui-right .ui-resizable-w {
278278 left: 0px !important;
279279 }
280280
281 -.wikiEditor-ui-right .wikiEditor-ui-toc-resize-grip{
282 - width:5px;
283 - height:12px;
284 - padding:3px;
285 - position:absolute;
286 - top:7px;
287 - left:-12px !important;
288 - cursor:ew-resize;
289 - background:url(../images/wikiEditor/toc/grip.png) 50% 50% no-repeat;
 281+.wikiEditor-ui-right .wikiEditor-ui-toc-resize-grip {
 282+ width: 5px;
 283+ height: 12px;
 284+ padding: 3px;
 285+ position: absolute;
 286+ top: 7px;
 287+ left: -12px !important;
 288+ cursor: ew-resize;
 289+ background: url(../images/wikiEditor/toc/grip.png) 50% 50% no-repeat;
290290 }
291 -.wikiEditor-ui-toolbar .tab-toc{
292 - float:right;
293 - margin:3px 16px 3px 3px;
294 - line-height:26px;
 291+.wikiEditor-ui-toolbar .tab-toc {
 292+ float: right;
 293+ margin: 3px 16px 3px 3px;
 294+ line-height: 26px;
295295 }
296 -.wikiEditor-ui-toc-expandControl{
 296+.wikiEditor-ui-toc-expandControl {
297297 position: absolute;
298 - z-index:2;
299 - top:0px;
300 - right:10px;
 298+ z-index: 2;
 299+ top: 0px;
 300+ right: 10px;
301301 height: 26px;
302302 padding: 3px 0;
303303 line-height: 26px;
304304 padding-right: 1em;
305 - white-space:nowrap;
306 - overflow:hidden;
 305+ white-space: nowrap;
 306+ overflow: hidden;
307307 }
308 -.wikiEditor-ui-text textarea{
309 - resize:none;
 308+.wikiEditor-ui-text textarea {
 309+ resize: none;
310310 }
311 -.wikiEditor-ui-text textarea:focus {outline:none;}
 311+.wikiEditor-ui-text textarea:focus {
 312+ outline: none;
 313+}
312314
313315 /* wikiEditor toolbar module */
314316
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -284,7 +284,9 @@
285285 .wikiEditor-ui-text textarea{
286286 resize:none;
287287 }
288 -.wikiEditor-ui-text textarea:focus{outline:none;}
 288+.wikiEditor-ui-text textarea:focus{
 289+outline:none;
 290+}
289291 .wikiEditor-ui-toolbar{
290292 position:relative;
291293 width:100%;

Status & tagging log