r59305 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59304‎ | r59305 | r59306 >
Date:03:01, 21 November 2009
Author:mrzman
Status:reverted
Tags:
Comment:
Fix from r59152
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
@@ -479,7 +479,7 @@
480480 if ( show ) {
481481 $section.fadeIn( 'fast' );
482482 dH = $section.outerHeight() - dH;
483 - context.modules.$toc.animate({'height': "+="+dH}, $section.outerHeight() * 2);
 483+ context.modules.$toolbar.animate({'height': "+="+dH}, $section.outerHeight() * 2);
484484 $sections.animate( { 'height': $section.outerHeight() }, $section.outerHeight() * 2, function() {
485485 $(this).css('overflow', 'visible').css('height', 'auto');
486486 } );
@@ -489,7 +489,7 @@
490490 .animate( { 'height': 0 }, $section.outerHeight() * 2, function() {
491491 $(this).css('overflow', 'visible');
492492 } );
493 - context.modules.$toc.animate({'height': "-="+$section.outerHeight()}, $section.outerHeight() * 2);
 493+ context.modules.$toolbar.animate({'height': "-="+$section.outerHeight()}, $section.outerHeight() * 2);
494494 }
495495 // Click tracking
496496 if($.trackAction != undefined){
@@ -590,7 +590,7 @@
591591 var $section = s.$sections.find( '.section:visible' );
592592 if ( $section.size() ) {
593593 $sections.animate( { 'height': $section.outerHeight() }, $section.outerHeight() * 2, function( ) {
594 - context.modules.$toc.height(
 594+ context.modules.$toolbar.height(
595595 context.$ui.find( '.wikiEditor-ui-left' )
596596 .outerHeight() - context.$ui.find( '.tab-toc' ).outerHeight()
597597 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r59307Revert r59305: makes toolbar overlap iframecatrope13:11, 21 November 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59152migrating the toc resizing to use jquery ui resizableadam23:26, 16 November 2009

Status & tagging log