r59225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59224‎ | r59225 | r59226 >
Date:22:36, 18 November 2009
Author:diana
Status:resolved (Comments)
Tags:
Comment:
add tracking field to transaction
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -780,9 +780,9 @@
781781 //enable if we need this to get the Civi data to display correctly
782782 $transaction['optout'] = ($transaction['optout'] == "1") ? '0' : '1';
783783 $transaction['anonymous'] = ($transaction['anonymous'] == "1") ? '0' : '1';
784 -
 784+ var_dump($transaction);
785785 // hook to call stomp functions
786 - wfRunHooks( 'gwStomp', array( &$transaction ) );
 786+ //wfRunHooks( 'gwStomp', array( &$transaction ) );
787787 }
788788
789789 /**
@@ -815,7 +815,7 @@
816816 $wgOut->addHTML( '<h3 class="response_message">' . $declinedDefault . $responseMsg . '</h3>' );
817817 }
818818
819 - function fnPayflowSaveContributionTracking( $data ) {
 819+ function fnPayflowSaveContributionTracking( &$data ) {
820820 $db = payflowGatewayConnection();
821821
822822 if (!$db) { return true ; }
@@ -843,7 +843,8 @@
844844
845845 // Store the contribution data
846846 if ($db->insert( 'contribution_tracking', $tracked_contribution ) ) {
847 - return true;
 847+ $data['contribution_tracking_id'] = $db->insertId();
 848+ return true;
848849 } else { return false; }
849850
850851 }

Comments

#Comment by Tfinc (talk | contribs)   01:11, 19 November 2009

Looks like extra debugging made its way in here.

#Comment by Tim Starling (talk | contribs)   05:22, 17 December 2009

The debugging changes were reverted in r59235.

Status & tagging log