r59214 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59213‎ | r59214 | r59215 >
Date:20:57, 18 November 2009
Author:catrope
Status:ok
Tags:
Comment:
wmf-deployment: Merge r59212
Modified paths:
  • /branches/wmf-deployment/extensions/UsabilityInitiative (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.js (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/OptIn (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)
  • /branches/wmf-deployment/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Property changes on: branches/wmf-deployment/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php
___________________________________________________________________
Modified: svn:mergeinfo
11 Merged /trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php:r59212
Property changes on: branches/wmf-deployment/extensions/UsabilityInitiative/OptIn
___________________________________________________________________
Modified: svn:mergeinfo
22 Merged /trunk/extensions/UsabilityInitiative/OptIn:r59212
Property changes on: branches/wmf-deployment/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.js
___________________________________________________________________
Modified: svn:mergeinfo
33 Merged /trunk/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.js:r59212
Index: branches/wmf-deployment/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -67,15 +67,15 @@
6868 array( 'src' => 'js/plugins/jquery.suggestions.js', 'version' => 6 ),
6969 array( 'src' => 'js/plugins/jquery.textSelection.js', 'version' => 18 ),
7070 array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 14 ),
71 - array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 23 ),
 71+ array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 24 ),
7272 array( 'src' => 'js/plugins/jquery.wikiEditor.dialogs.js', 'version' => 8 ),
7373 array( 'src' => 'js/plugins/jquery.wikiEditor.toc.js', 'version' => 27 ),
7474 ),
7575 'combined' => array(
76 - array( 'src' => 'js/plugins.combined.js', 'version' => 67 ),
 76+ array( 'src' => 'js/plugins.combined.js', 'version' => 68 ),
7777 ),
7878 'minified' => array(
79 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 67 ),
 79+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 68 ),
8080 ),
8181 ),
8282 );
Property changes on: branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking
___________________________________________________________________
Modified: svn:mergeinfo
8383 Merged /trunk/extensions/UsabilityInitiative/ClickTracking:r59212
Property changes on: branches/wmf-deployment/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
___________________________________________________________________
Modified: svn:mergeinfo
8484 Merged /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js:r59212
Index: branches/wmf-deployment/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
@@ -275,7 +275,7 @@
276276 var label = $.wikiEditor.autoMsg( tool, 'label' );
277277 switch ( tool.type ) {
278278 case 'button':
279 - var src = tool.icon;
 279+ var src = tool.icon + '?' + wgWikiEditorIconVersion;
280280 if ( src.indexOf( 'http://' ) !== 0 && src.indexOf( 'https://' ) !== 0 ) {
281281 src = $.wikiEditor.imgPath + 'toolbar/' + src;
282282 }
Property changes on: branches/wmf-deployment/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
___________________________________________________________________
Modified: svn:mergeinfo
283283 Merged /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js:r59212
Index: branches/wmf-deployment/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -1915,7 +1915,7 @@
19161916 var label = $.wikiEditor.autoMsg( tool, 'label' );
19171917 switch ( tool.type ) {
19181918 case 'button':
1919 - var src = tool.icon;
 1919+ var src = tool.icon + '?' + wgWikiEditorIconVersion;
19201920 if ( src.indexOf( 'http://' ) !== 0 && src.indexOf( 'https://' ) !== 0 ) {
19211921 src = $.wikiEditor.imgPath + 'toolbar/' + src;
19221922 }
Index: branches/wmf-deployment/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -121,7 +121,7 @@
122122 break;case'dialog':context.$textarea.wikiEditor('openDialog',{'dialog':action.module});break;default:break;}},buildGroup:function(context,id,group){var $group=$('<div />').attr({'class':'group group-'+id,'rel':id});var label=$.wikiEditor.autoMsg(group,'label');if(label){$group.append('<div class="label">'+label+'</div>')}
123123 var empty=true;if('tools'in group){for(tool in group.tools){var tool=$.wikiEditor.modules.toolbar.fn.buildTool(context,tool,group.tools[tool]);if(tool){empty=false;$group.append(tool);}}}
124124 return empty?null:$group;},buildTool:function(context,id,tool){if('filters'in tool){for(filter in tool.filters){if($(tool.filters[filter]).size()==0){return null;}}}
125 -var label=$.wikiEditor.autoMsg(tool,'label');switch(tool.type){case'button':var src=tool.icon;if(src.indexOf('http://')!==0&&src.indexOf('https://')!==0){src=$.wikiEditor.imgPath+'toolbar/'+src;}
 125+var label=$.wikiEditor.autoMsg(tool,'label');switch(tool.type){case'button':var src=tool.icon+'?'+wgWikiEditorIconVersion;if(src.indexOf('http://')!==0&&src.indexOf('https://')!==0){src=$.wikiEditor.imgPath+'toolbar/'+src;}
126126 $button=$('<img />').attr({'src':src,'width':22,'height':22,'alt':label,'title':label,'rel':id,'class':'tool tool-button'});if('action'in tool){$button.data('action',tool.action).data('context',context).click(function(){$.wikiEditor.modules.toolbar.fn.doAction($(this).data('context'),$(this).data('action'),$(this));return false;});}
127127 return $button;case'select':var $select=$('<div />').attr({'rel':id,'class':'tool tool-select'}).click(function(){var $options=$(this).find('.options');$options.animate({'opacity':'toggle'},'fast');});$options=$('<div />').addClass('options');if('list'in tool){for(option in tool.list){var optionLabel=$.wikiEditor.autoMsg(tool.list[option],'label');$options.append($('<a />').data('action',tool.list[option].action).data('context',context).click(function(){$.wikiEditor.modules.toolbar.fn.doAction($(this).data('context'),$(this).data('action'),$(this));}).text(optionLabel).addClass('option').attr('rel',option));}}
128128 $select.append($('<div />').addClass('menu').append($options));$select.append($('<div />').addClass('label').text(label));return $select;default:return null;}},buildBookmark:function(context,id,page){var label=$.wikiEditor.autoMsg(page,'label');return $('<div />').text(label).attr('rel',id).data('context',context).bind('mousedown',function(){$(this).parent().parent().find('.page').hide();$(this).parent().parent().find('.page-'+$(this).attr('rel')).show();$(this).siblings().removeClass('current');$(this).addClass('current');var section=$(this).parent().parent().attr('rel');if($.trackAction!=undefined){$.trackAction(section+'.'+$(this).attr('rel'));}
Property changes on: branches/wmf-deployment/extensions/UsabilityInitiative
___________________________________________________________________
Modified: svn:mergeinfo
129129 Merged /trunk/extensions/UsabilityInitiative:r59212

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59212USabilityInitiative: Add support for versioning toolbar iconscatrope20:53, 18 November 2009

Status & tagging log