r59211 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59210‎ | r59211 | r59212 >
Date:20:50, 18 November 2009
Author:aaron
Status:ok
Tags:
Comment:
last tweak for bug 21352 (RevDelete messages)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialDeletedContributions.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -670,6 +670,7 @@
671671 'rev-suppressed-unhide-diff',
672672 'rev-deleted-diff-view',
673673 'rev-suppressed-diff-view',
 674+ 'rev-deleted-user-contribs',
674675 'rev-delundel',
675676 'rev-showdeleted',
676677 'revisiondelete',
Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -645,7 +645,7 @@
646646
647647 # Denote if username is redacted for this edit
648648 if( $rev->isDeleted( Revision::DELETED_USER ) ) {
649 - $ret .= " <strong>" . wfMsgHtml('rev-deleted-user') . "</strong>";
 649+ $ret .= " <strong>" . wfMsgHtml('rev-deleted-user-contribs') . "</strong>";
650650 }
651651
652652 # Tags, if any.
Index: trunk/phase3/includes/specials/SpecialDeletedContributions.php
@@ -123,7 +123,7 @@
124124 'user_text' => $row->ar_user_text,
125125 'timestamp' => $row->ar_timestamp,
126126 'minor_edit' => $row->ar_minor_edit,
127 - 'deleted' => $row->ar_deleted,
 127+ 'deleted' => $row->ar_deleted,
128128 ) );
129129
130130 $page = Title::makeTitle( $row->ar_namespace, $row->ar_title );
@@ -212,12 +212,15 @@
213213 array( 'class' => 'mw-deletedcontribs-tools' ),
214214 wfMsg( 'parentheses', $wgLang->pipeList( array( $last, $dellog, $reviewlink ) ) )
215215 );
 216+
 217+ $ret = "{$del}{$link} {$tools} . . {$mflag} {$pagelink} {$comment}";
 218+
 219+ # Denote if username is redacted for this edit
 220+ if( $rev->isDeleted( Revision::DELETED_USER ) ) {
 221+ $ret .= " <strong>" . wfMsgHtml('rev-deleted-user-contribs') . "</strong>";
 222+ }
216223
217 - $ret = Html::rawElement(
218 - 'li',
219 - array(),
220 - "{$del}{$link} {$tools} . . {$mflag} {$pagelink} {$comment}"
221 - ) . "\n";
 224+ $ret = Html::rawElement( 'li', array(), $ret ) . "\n";
222225
223226 wfProfileOut( __METHOD__ );
224227 return $ret;
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1427,6 +1427,7 @@
14281428 'rev-deleted-comment' => '(comment removed)',
14291429 'rev-deleted-user' => '(username removed)',
14301430 'rev-deleted-event' => '(log action removed)',
 1431+'rev-deleted-user-contribs' => '[username or IP removed - edit hidden from contributions]',
14311432 'rev-deleted-text-permission' => "This page revision has been '''deleted'''.
14321433 There may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
14331434 'rev-deleted-text-unhide' => "This page revision has been '''deleted'''.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58394plural tweak for bug 21352aaron20:51, 31 October 2009
r59020Tweak for bug 21352aaron19:56, 13 November 2009

Status & tagging log