r59176 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59175‎ | r59176 | r59177 >
Date:18:16, 17 November 2009
Author:tparscal
Status:ok
Tags:
Comment:
Added CSS for 2009 fundraiser to make the data visible. Also made some adjustments on the bar width and other small CSS issues.
Modified paths:
  • /trunk/extensions/ContributionReporting/FundraiserStatistics.css (modified) (history)
  • /trunk/extensions/ContributionReporting/FundraiserStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributionReporting/FundraiserStatistics_body.php
@@ -79,7 +79,7 @@
8080 $days = $this->getDailyTotals( $fundraiser['start'], $fundraiser['end'] );
8181 foreach( $sources as $chart => $source ) {
8282 $column = 0;
83 - $factor = 200 / $max[$source];
 83+ $factor = 300 / $max[$source];
8484 // Build bars for chart
8585 foreach( $days as $i => $day ) {
8686 $height = $factor * $day[$source];
@@ -129,7 +129,7 @@
130130 ) .
131131 Xml::tags( 'tr', null,
132132 Xml::element( 'td', $tdLabelAttributes, wfMsg( 'fundraiserstats-contributions' ) ) .
133 - Xml::element( 'td', $tdValueAttributes, $wgLang->formatNum( number_format( $day[2], 2 ) ) ) .
 133+ Xml::element( 'td', $tdValueAttributes, $wgLang->formatNum( number_format( $day[2] ) ) ) .
134134 Xml::element( 'td', $tdLabelAttributes, wfMsg( 'fundraiserstats-avg' ) ) .
135135 Xml::element( 'td', $tdValueAttributes, $wgLang->formatNum( number_format( $day[3], 2 ) ) )
136136 )
Index: trunk/extensions/ContributionReporting/FundraiserStatistics.css
@@ -1,7 +1,10 @@
22 .fundraiserstats-view-box {
3 - width: 100%;
43 border: solid 1px silver;
54 }
 5+.fundraiserstats-view-box h3 {
 6+ margin-top: 0;
 7+ padding-top: 0;
 8+}
69 .fundraiserstats-today {
710 position: absolute;
811 width: 6px;
@@ -13,16 +16,21 @@
1417 .fundraiserstats-bar-2007 {
1518 background-color: #AAAAFF;
1619 border: outset 1px #AAAAFF;
17 - width: 3px;
 20+ width: 2px;
1821 margin-left: 3px;
1922 }
2023 .fundraiserstats-bar-2008 {
2124 background-color: #AAFFAA;
2225 border: outset 1px #AAFFAA;
23 - width: 3px;
 26+ width: 2px;
2427 }
 28+.fundraiserstats-bar-2009 {
 29+ background-color: #FFAAAA;
 30+ border: outset 1px #FFAAAA;
 31+ width: 2px;
 32+}
2533 .fundraiserstats-bar-space {
26 - width: 3px;
 34+ width: 2px;
2735 }
2836 .fundraiserstats-chart {
2937 padding: 10px;

Follow-up revisions

RevisionCommit summaryAuthorDate
r59209picking up r59176tomasz19:59, 18 November 2009

Status & tagging log