r59171 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59170‎ | r59171 | r59172 >
Date:14:15, 17 November 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Modified paths:
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -23,7 +23,7 @@
2424 die( 'Not an entry point.' );
2525 }
2626
27 -define('SM_VERSION', '0.4.2 rc2');
 27+define('SM_VERSION', '0.5 a1');
2828
2929 $smgScriptPath = $wgScriptPath . '/extensions/SemanticMaps';
3030 $smgIP = $IP . '/extensions/SemanticMaps';
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php
@@ -55,10 +55,8 @@
5656 */
5757 protected function addSpecificMapHTML() {
5858 global $wgJsMimeType;
59 -
60 - $enableEarth = MapsGoogleMapsUtils::getEarthValue($this->earth);
6159
62 - // Get the Google Maps names for the control and map types
 60+ // Get the Google Maps names for the control and map types.
6361 $this->type = MapsGoogleMapsUtils::getGMapType($this->type, true);
6462
6563 $this->controls = MapsGoogleMapsUtils::createControlsString($this->controls);
@@ -83,7 +81,7 @@
8482
8583 $this->types = explode(",", $this->types);
8684
87 - $typesString = MapsGoogleMapsUtils::createTypesString($this->types, $enableEarth);
 85+ $typesString = MapsGoogleMapsUtils::createTypesString($this->types);
8886
8987 $this->output .= <<<END
9088 <div id="$this->mapName" class="$this->class" style="$this->style" ></div>
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -73,8 +73,6 @@
7474 protected function addSpecificMapHTML() {
7575 global $wgJsMimeType;
7676
77 - $enableEarth = MapsGoogleMapsUtils::getEarthValue($this->earth);
78 -
7977 $this->autozoom = MapsGoogleMapsUtils::getAutozoomJSValue($this->autozoom);
8078
8179 $this->type = MapsGoogleMapsUtils::getGMapType($this->type, true);
@@ -88,7 +86,7 @@
8987
9088 $this->types = explode(",", $this->types);
9189
92 - $typesString = MapsGoogleMapsUtils::createTypesString($this->types, $enableEarth);
 90+ $typesString = MapsGoogleMapsUtils::createTypesString($this->types);
9391
9492 $this->output .= "
9593 <div id='".$this->mapName."' class='".$this->class."'></div>

Status & tagging log