r59097 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59096‎ | r59097 | r59098 >
Date:13:29, 15 November 2009
Author:vrandezo
Status:deferred
Tags:
Comment:
Replaced deprecated split with explode
Modified paths:
  • /trunk/extensions/Maps/ParserFunctions/Maps_ParserGeocoder.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/ParserFunctions/Maps_ParserGeocoder.php
@@ -36,7 +36,7 @@
3737
3838 // Get the service and geoservice from the parameters, since they are needed to geocode addresses.
3939 for ($i = 0; $i < count($params); $i++) {
40 - $split = split('=', $params[$i]);
 40+ $split = explode('=', $params[$i]);
4141 if (MapsMapper::inParamAliases(strtolower(trim($split[0])), 'service') && count($split) > 1) {
4242 $service = trim($split[1]);
4343 }
@@ -51,7 +51,7 @@
5252
5353 // Go over all parameters.
5454 for ($i = 0; $i < count($params); $i++) {
55 - $split = split('=', $params[$i]);
 55+ $split = explode('=', $params[$i]);
5656 $isAddress = (strtolower(trim($split[0])) == 'address' || strtolower(trim($split[0])) == 'addresses') && count($split) > 1;
5757 $isDefault = count($split) == 1;
5858

Status & tagging log