r58971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58970‎ | r58971 | r58972 >
Date:20:41, 12 November 2009
Author:catrope
Status:deferred
Tags:
Comment:
usability: Merge r58969 (CollapsibleTabs bouncing fix) from trunk to acaifix
Modified paths:
  • /branches/usability/acaifix/CollapsibleTabs/CollapsibleTabs.js (modified) (history)
  • /branches/usability/acaifix/CollapsibleTabs/CollapsibleTabs.php (modified) (history)

Diff [purge]

Index: branches/usability/acaifix/CollapsibleTabs/CollapsibleTabs.php
@@ -18,7 +18,7 @@
1919
2020 /* Configuration */
2121 // Bump the version number every time you change any of the .css/.js files
22 -$wgCollapsibleTabsStyleVersion = 8;
 22+$wgCollapsibleTabsStyleVersion = 9;
2323
2424 /* Setup */
2525
Index: branches/usability/acaifix/CollapsibleTabs/CollapsibleTabs.js
@@ -52,10 +52,10 @@
5353 }).collapsibleTabs({
5454 expandCondition: function(eleWidth) {
5555 if( rtl ){
56 - return ( $j('#right-navigation').position().left + $j('#right-navigation').width())
 56+ return ( $j('#right-navigation').position().left + $j('#right-navigation').width() + 1)
5757 < ($j('#left-navigation').position().left - eleWidth);
5858 } else {
59 - return ( $j('#left-navigation').position().left + $j('#left-navigation').width())
 59+ return ( $j('#left-navigation').position().left + $j('#left-navigation').width() + 1)
6060 < ($j('#right-navigation').position().left - eleWidth);
6161 }
6262 },
Property changes on: branches/usability/acaifix/CollapsibleTabs/CollapsibleTabs.js
___________________________________________________________________
Added: svn:mergeinfo
6363 Merged /trunk/phase3/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.js:r56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447
6464 Merged /trunk/extensions/UsabilityInitiative/Vector/Modules/CollapsibleTabs/CollapsibleTabs.js:r58969
6565 Merged /branches/REL1_15/phase3/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.js:r51646
6666 Merged /trunk/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.js:r56151-57234,58926

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58969Fixing a bug on collapsible tabs where the tabs would get stuck alternating b...adam20:36, 12 November 2009

Status & tagging log