r58934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58933‎ | r58934 | r58935 >
Date:03:11, 12 November 2009
Author:simetrical
Status:reverted (Comments)
Tags:
Comment:
Upper-case DOCTYPE in HTML5 for well-formedness

Apparently <!doctype html> is a syntax error in XML; <!DOCTYPE html> is
required. Now I know. This broke Twinkle and probably lots of other stuff, so
it would be good to sync this ASAP. Sorry for the error.
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1791,7 +1791,7 @@
17921792 $dir = $wgContLang->getDir();
17931793
17941794 if ( $wgHtml5 ) {
1795 - $ret .= "<!doctype html>\n";
 1795+ $ret .= "<!DOCTYPE html>\n";
17961796 $ret .= "<html lang=\"$wgContLanguageCode\" dir=\"$dir\">\n";
17971797 } else {
17981798 $ret .= "<!DOCTYPE html PUBLIC \"$wgDocType\" \"$wgDTD\">\n";

Comments

#Comment by Simetrical (talk | contribs)   23:52, 10 December 2009

This was replaced by r59741, which actually fixed the well-formedness errors.

Status & tagging log