r58932 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58931‎ | r58932 | r58933 >
Date:00:43, 12 November 2009
Author:brion
Status:deferred
Tags:
Comment:
Fix total regression in ability to act as OpenID server in r52236.
An "else" line got dropped, causing the logic for outputting the X-XRDS-Location header on user pages to never get run when we need it; without the discovery header, clients would never be able to connect to your provider.
Modified paths:
  • /trunk/extensions/OpenID/OpenID.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.hooks.php
@@ -56,6 +56,7 @@
5757 "<a href='$url'>$disp</a>" .
5858 "</span>" );
5959 }
 60+ } else {
6061 # Add OpenID data if its allowed
6162 if ( !$wgOpenIDClientOnly ) {
6263 $st = SpecialPage::getTitleFor( 'OpenIDServer' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52236Big changes to OpenID extension:...ialex12:41, 21 June 2009

Status & tagging log