r58870 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58869‎ | r58870 | r58871 >
Date:19:39, 10 November 2009
Author:tparscal
Status:ok
Tags:
Comment:
Simple search auto-hiding label was rendering wrong in IE6 because IE6 was assuming some strange default for the 'top' css property - now we just specify it as 0.25em and things look good everywhere. Also, in RTL, there was a double-thick blue line next to the search box in some browsers, which is now fixed.
Modified paths:
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -208,6 +208,7 @@
209209 body.rtl div.vectorMenu {
210210 direction: rtl;
211211 }
 212+ /* OVERRIDDEN BY COMPLIANT BROWSERS */
212213 /* @noflip */
213214 #head div.vectorMenu h5 {
214215 float: left;
——@@ -218,6 +219,10 @@
219220 margin-left: -1px;
220221 font-size:100% !important;
221222 }
 223+ /* IGNORED BY IE6 */
 224+ #head div.vectorMenu > h5 {
 225+ background-image: none;
 226+ }
222227 /* OVERRIDDEN BY COMPLIANT BROWSERS */
223228 div.vectorMenu h5 a {
224229 display: inline-block;
——@@ -332,6 +337,7 @@
333338 }
334339 #simpleSearch label {
335340 font-size: 0.8em;
 341+ top: 0.25em;
336342 }
337343 #simpleSearch input#searchInput {
338344 margin: 0;
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -208,6 +208,7 @@
209209 body.rtl div.vectorMenu {
210210 direction: rtl;
211211 }
 212+ /* OVERRIDDEN BY COMPLIANT BROWSERS */
212213 /* @noflip */
213214 #head div.vectorMenu h5 {
214215 float: left;
——@@ -218,6 +219,10 @@
219220 margin-left: -1px;
220221 font-size:100% !important;
221222 }
 223+ /* IGNORED BY IE6 */
 224+ #head div.vectorMenu > h5 {
 225+ background-image: none;
 226+ }
222227 /* OVERRIDDEN BY COMPLIANT BROWSERS */
223228 div.vectorMenu h5 a {
224229 display: inline-block;
——@@ -332,6 +337,7 @@
333338 }
334339 #simpleSearch label {
335340 font-size: 0.8em;
 341+ top: 0.25em;
336342 }
337343 #simpleSearch input#searchInput {
338344 margin: 0;

Status & tagging log