r58724 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58723‎ | r58724 | r58725 >
Date:18:00, 7 November 2009
Author:ashley
Status:deferred
Tags:
Comment:
DataCenter: coding style cleanup for UI/Layouts
Modified paths:
  • /trunk/extensions/DataCenter/UI/Layouts/Columns.php (modified) (history)
  • /trunk/extensions/DataCenter/UI/Layouts/Rows.php (modified) (history)
  • /trunk/extensions/DataCenter/UI/Layouts/Tabs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DataCenter/UI/Layouts/Tabs.php
@@ -21,9 +21,7 @@
2222
2323 /* Functions */
2424
25 - public static function render(
26 - array $parameters
27 - ) {
 25+ public static function render( array $parameters ) {
2826 // Increment the number of tabbed layouts in existence
2927 self::$sets++;
3028 // Gets id for this set
@@ -112,10 +110,7 @@
113111 }
114112 }
115113 },
116 - addSet: function(
117 - name,
118 - count
119 - ) {
 114+ addSet: function( name, count ) {
120115 this.sets[name] = {};
121116 this.sets[name].count = count;
122117 }
Index: trunk/extensions/DataCenter/UI/Layouts/Rows.php
@@ -20,9 +20,7 @@
2121
2222 /* Functions */
2323
24 - public static function render(
25 - array $parameters
26 - ) {
 24+ public static function render( array $parameters ) {
2725 // Begins layout
2826 $xmlOutput = parent::begin( self::$parameters['class'] );
2927 // Loops over each content block
Index: trunk/extensions/DataCenter/UI/Layouts/Columns.php
@@ -20,9 +20,7 @@
2121
2222 /* Functions */
2323
24 - public static function render(
25 - array $parameters
26 - ) {
 24+ public static function render( array $parameters ) {
2725 // Begins layout
2826 $xmlOutput = parent::begin( self::$parameters['class'] );
2927 // Calculates split percentage

Status & tagging log