r58641 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58640‎ | r58641 | r58642 >
Date:13:16, 6 November 2009
Author:catrope
Status:deferred
Tags:
Comment:
UsabilityInitiative: Fix copy-paste mistake. Vector has no global scripts, so trying to add them results in adding "/Vector/?252", which causes the client to interpret a directory index file as JS (or get a 403)
Modified paths:
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -8,7 +8,6 @@
99
1010 class VectorHooks {
1111
12 - static $scripts = null;
1312 static $modules = array(
1413 'collapsibletabs' => array(
1514 'scripts' => array(
@@ -107,12 +106,6 @@
108107 }
109108 }
110109 }
111 - // Prepend global script
112 - $mode = $wgUsabilityInitiativeResourceMode;
113 - if ( !isset( self::$scripts[$mode] ) ) {
114 - $mode = 'raw';
115 - }
116 - array_unshift( $scripts, self::$scripts[$mode] );
117110 // Add all scripts
118111 foreach ( $scripts as $script ) {
119112 UsabilityInitiativeHooks::addScript(

Status & tagging log