r58588 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58587‎ | r58588 | r58589 >
Date:16:42, 5 November 2009
Author:aaron
Status:ok
Tags:
Comment:
Use 'self' rather than class name
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevision.php
@@ -104,7 +104,7 @@
105105 );
106106 # Sorted from highest to lowest, so just take the first one if any
107107 if( $row ) {
108 - $frev = new FlaggedRevision( $row );
 108+ $frev = new self( $row );
109109 $frev->mTitle = $title;
110110 return $frev;
111111 }
@@ -204,7 +204,7 @@
205205 if( !$row ) return null;
206206 }
207207 }
208 - $frev = new FlaggedRevision( $row );
 208+ $frev = new self( $row );
209209 $frev->mTitle = $title;
210210 return $frev;
211211 }
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -15,7 +15,7 @@
1616 */
1717 public static function singleton() {
1818 if( self::$instance == null ) {
19 - self::$instance = new FlaggedArticleView();
 19+ self::$instance = new self();
2020 }
2121 return self::$instance;
2222 }

Status & tagging log