r58580 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58579‎ | r58580 | r58581 >
Date:13:14, 5 November 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* remove comma from 'wikilog-post-count-published' which I accidentally left behind in r58311
* add a comment in WikilogMainPage.php about the messages that are used but are hard to grep otherwise (also format the makeKnownLinkObj() differently
Modified paths:
  • /trunk/extensions/Wikilog/Wikilog.i18n.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogMainPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikilog/WikilogMainPage.php
@@ -218,8 +218,15 @@
219219 */
220220 private function formatPostCount( $skin, $elem, $type, $num ) {
221221 global $wgWikilogFeedClasses;
222 - $s = $skin->makeKnownLinkObj( $this->mTitle,
223 - wfMsgExt( "wikilog-post-count-{$type}", array( 'parsemag' ), $num ),
 222+
 223+ // Uses messages 'wikilog-post-count-published', 'wikilog-post-count-drafts', 'wikilog-post-count-all'
 224+ $s = $skin->makeKnownLinkObj(
 225+ $this->mTitle,
 226+ wfMsgExt(
 227+ "wikilog-post-count-{$type}",
 228+ array( 'parsemag' ),
 229+ $num
 230+ ),
224231 "view=archives&show={$type}"
225232 );
226233 if ( !empty( $wgWikilogFeedClasses ) ) {
Index: trunk/extensions/Wikilog/Wikilog.i18n.php
@@ -32,7 +32,7 @@
3333 'wikilog-tab' => 'Wikilog',
3434 'wikilog-tab-title' => 'Wikilog actions',
3535 'wikilog-information' => 'Wikilog information',
36 - 'wikilog-post-count-published' => 'There {{PLURAL:$1|is one published article|are $1 published articles}} in this wikilog,',
 36+ 'wikilog-post-count-published' => 'There {{PLURAL:$1|is one published article|are $1 published articles}} in this wikilog',
3737 'wikilog-post-count-drafts' => 'There {{PLURAL:$1|is one unpublished (draft) article|are $1 unpublished (draft) articles}},',
3838 'wikilog-post-count-all' => 'In total there {{PLURAL:$1|is one article|are $1 articles}}.',
3939 'wikilog-new-item' => 'Create new wikilog article',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58311* Some i18n review and preparations for l10n...siebrand13:14, 29 October 2009

Status & tagging log