r58426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58425‎ | r58426 | r58427 >
Date:11:53, 2 November 2009
Author:catrope
Status:deferred
Tags:
Comment:
* NavigableTOC: (bug 21201) Display hand cursor over highlighted sections in NTOC
* EditToolbar: Fix display of status image in link dialog by adding a <br />
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.toc.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.toc.css
——@@ -66,7 +66,6 @@
6767 .wikiEditor-ui-toc ul li div.current {
6868 background-color: #FAFAFA;
6969 color: #333333;
70 - cursor: default;
7170 }
7271 .wikiEditor-ui-toc ul li div.section-0 {
7372 font-size: 1em;
Index: trunk/extensions/UsabilityInitiative/css/combined.css
——@@ -171,7 +171,6 @@
172172 .wikiEditor-ui-toc ul li div.current {
173173 background-color: #FAFAFA;
174174 color: #333333;
175 - cursor: default;
176175 }
177176 .wikiEditor-ui-toc ul li div.section-0 {
178177 font-size: 1em;
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
——@@ -158,7 +158,6 @@
159159 .wikiEditor-ui-toc ul li div.current{
160160 background-color:#FAFAFA;
161161 color:#333333;
162 -cursor:default;
163162 }
164163 .wikiEditor-ui-toc ul li div.section-0{
165164 font-size:1em;
——@@ -501,4 +500,4 @@
502501 background-color:white;
503502 text-decoration:none;
504503 border-color:#a8d7f9;
505 -}
 504+}
\ No newline at end of file
Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
——@@ -22,15 +22,15 @@
2323 array( 'src' => 'css/wikiEditor.css', 'version' => 4 ),
2424 array( 'src' => 'css/wikiEditor.toolbar.css', 'version' => 7 ),
2525 array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 2 ),
26 - array( 'src' => 'css/wikiEditor.toc.css', 'version' => 7 ),
 26+ array( 'src' => 'css/wikiEditor.toc.css', 'version' => 8 ),
2727 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2' ),
2828 ),
2929 'combined' => array(
30 - array( 'src' => 'css/combined.css', 'version' => 13 ),
 30+ array( 'src' => 'css/combined.css', 'version' => 14 ),
3131 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2' ),
3232 ),
3333 'minified' => array(
34 - array( 'src' => 'css/combined.min.css', 'version' => 13 ),
 34+ array( 'src' => 'css/combined.min.css', 'version' => 14 ),
3535 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2' ),
3636 ),
3737 )
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
——@@ -944,6 +944,7 @@
945945 var externalMsg = gM( 'edittoolbar-tool-link-int-target-status-external' );
946946 var loadingMsg = gM( 'edittoolbar-tool-link-int-target-status-loading' );
947947 $j( '#edittoolbar-link-int-target-status' )
 948+ .before( $j( '<br />' ) )
948949 .append( $j( '<img />' ).attr( {
949950 'id': 'edittoolbar-link-int-target-status-exists',
950951 'src': $j.wikiEditor.imgPath + 'dialogs/' + 'insert-link-exists.png',
——@@ -1137,7 +1138,7 @@
11381139 $j(this).data( 'articlePathRegex', new RegExp(
11391140 '^' + RegExp.escape( wgServer + wgArticlePath )
11401141 .replace( /\\\$1/g, '(.*)' ) + '$'
1141 - ) );
 1142+ ) );
11421143 // Pre-fill the text fields based on the current selection
11431144 var selection = $j(this).data( 'context' ).$textarea.getSelection();
11441145 $j( '#edittoolbar-link-int-target' ).focus();
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.min.js
——@@ -39,7 +39,7 @@
4040 $j(this).find('[rel]').each(function(){$j(this).text(gM($j(this).attr('rel')));});$j('#edittoolbar-link-int-target').bind('change keypress paste cut',function(){setTimeout(function(){if(isExternalLink($j('#edittoolbar-link-int-target').val()))
4141 $j('#edittoolbar-link-type-ext').attr('checked','checked');else
4242 $j('#edittoolbar-link-type-int').attr('checked','checked');if($j('#edittoolbar-link-int-text').data('untouched'))
43 -$j('#edittoolbar-link-int-text').val($j('#edittoolbar-link-int-target').val());},0);});$j('#edittoolbar-link-int-text').bind('change keypress paste cut',function(){$j(this).data('untouched',false);});var existsMsg=gM('edittoolbar-tool-link-int-target-status-exists');var notexistsMsg=gM('edittoolbar-tool-link-int-target-status-notexists');var invalidMsg=gM('edittoolbar-tool-link-int-target-status-invalid');var externalMsg=gM('edittoolbar-tool-link-int-target-status-external');var loadingMsg=gM('edittoolbar-tool-link-int-target-status-loading');$j('#edittoolbar-link-int-target-status').append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-exists','src':$j.wikiEditor.imgPath+'dialogs/'+'insert-link-exists.png','alt':existsMsg,'title':existsMsg})).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-notexists','src':$j.wikiEditor.imgPath+'dialogs/'+'insert-link-notexists.png','alt':notexistsMsg,'title':notexistsMsg})).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-invalid','src':$j.wikiEditor.imgPath+'dialogs/'+'insert-link-invalid.png','alt':invalidMsg,'title':invalidMsg})).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-external','src':$j.wikiEditor.imgPath+'dialogs/'+'insert-link-external.png','alt':externalMsg,'title':externalMsg})).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-loading','src':$j.wikiEditor.imgPath+'dialogs/loading.gif','alt':loadingMsg,'title':loadingMsg})).data('existencecache',{}).children().hide();$j('#edittoolbar-link-int-target').bind('keypress paste cut',function(){if(typeof $j(this).data('timerID')!='undefined'){clearTimeout($j(this).data('timerID'));}
 43+$j('#edittoolbar-link-int-text').val($j('#edittoolbar-link-int-target').val());},0);});$j('#edittoolbar-link-int-text').bind('change keypress paste cut',function(){$j(this).data('untouched',false);});var existsMsg=gM('edittoolbar-tool-link-int-target-status-exists');var notexistsMsg=gM('edittoolbar-tool-link-int-target-status-notexists');var invalidMsg=gM('edittoolbar-tool-link-int-target-status-invalid');var externalMsg=gM('edittoolbar-tool-link-int-target-status-external');var loadingMsg=gM('edittoolbar-tool-link-int-target-status-loading');$j('#edittoolbar-link-int-target-status').before($j('<br />')).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-exists','src':$j.wikiEditor.imgPath+'dialogs/'+'insert-link-exists.png','alt':existsMsg,'title':existsMsg})).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-notexists','src':$j.wikiEditor.imgPath+'dialogs/'+'insert-link-notexists.png','alt':notexistsMsg,'title':notexistsMsg})).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-invalid','src':$j.wikiEditor.imgPath+'dialogs/'+'insert-link-invalid.png','alt':invalidMsg,'title':invalidMsg})).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-external','src':$j.wikiEditor.imgPath+'dialogs/'+'insert-link-external.png','alt':externalMsg,'title':externalMsg})).append($j('<img />').attr({'id':'edittoolbar-link-int-target-status-loading','src':$j.wikiEditor.imgPath+'dialogs/loading.gif','alt':loadingMsg,'title':loadingMsg})).data('existencecache',{}).children().hide();$j('#edittoolbar-link-int-target').bind('keypress paste cut',function(){if(typeof $j(this).data('timerID')!='undefined'){clearTimeout($j(this).data('timerID'));}
4444 var timerID=setTimeout(updateExistence,120);$j(this).data('timerID',timerID);}).change(function(){if(typeof $j(this).data('timerID')!='undefined'){clearTimeout($j(this).data('timerID'));}
4545 updateExistence();});$j('#edittoolbar-link-int-target').data('suggcache',{}).suggestions({fetch:function(query){var that=this;var title=$j(this).val();if(isExternalLink(title)||title.indexOf('|')!=-1||title==''){$j(this).suggestions('suggestions',[]);return;}
4646 var cache=$j(this).data('suggcache');if(typeof cache[title]!='undefined'){$j(this).suggestions('suggestions',cache[title]);return;}
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php
——@@ -19,7 +19,7 @@
2020 /* Configuration */
2121
2222 // Bump the version number every time you change any of the .css/.js files
23 -$wgEditToolbarStyleVersion = 69;
 23+$wgEditToolbarStyleVersion = 70;
2424
2525 // Set this to true to simply override the stock toolbar for everyone
2626 $wgEditToolbarGlobalEnable = false;

Follow-up revisions

RevisionCommit summaryAuthorDate
r59204wmf-deployment: Merging usability changes from trunk...catrope18:53, 18 November 2009

Status & tagging log