r58407 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r58406‎ \| r58407 \| r58408 >
Date:	21:34, 1 November 2009
Author:	siebrand
Status:	deferred (Comments)
Tags:
Comment:	Fix PHP Notice: Undefined index: lqtnotifytalk in extensions/LiquidThreads/classes/NewMessagesController.php on line 144. Needs review.
Modified paths:	/trunk/extensions/LiquidThreads/classes/NewMessagesController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/NewMessagesController.php
—	—	@@ -141,7 +141,7 @@
142	142	if ( $oldPrefCompat ) {
143	143	$decodedOptions = self::decodeUserOptions( $row->user_options );
144	144
145		~~- $wantsTalkNotification = ( is_null( $decodedOptions['lqtnotifytalk'] ) &&~~
	145	+ $wantsTalkNotification = ( ( !isset( $decodedOptions['lqtnotifytalk'] ) \|\| is_null( $decodedOptions['lqtnotifytalk'] ) ) &&
146	146	User::getDefaultOption( 'lqtnotifytalk' ) ) \|\| $row->up_value;
147	147	} else {
148	148	$wantsTalkNotification =

Revision	Commit summary	Author	Date
r66078	update r58407 to make it clearer.	mah	00:14, 9 May 2010

#Comment by MarkAHershberger (talk | contribs) 00:12, 9 May 2010

!isset() is enough in these circumstances.

The following all return the same no matter what $a is.

var_dump( !isset( $a['a'] ) );
@var_dump( is_null( $a['a'] ) );
var_dump( !isset( $a['a'] ) || is_null( $a['a'] ) );

00:53, 9 May 2010 MarkAHershberger (talk | contribs) changed the status of r58407 [removed: resolved added: deferred]
00:12, 9 May 2010 MarkAHershberger (talk | contribs) changed the status of r58407 [removed: deferred added: resolved]
02:10, 9 December 2009 Tim Starling (talk | contribs) changed the status of r58407 [removed: new added: deferred]