r58383 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58382‎ | r58383 | r58384 >
Date:02:36, 31 October 2009
Author:adam
Status:deferred
Tags:
Comment:
CollapsibleTabs: bugfix for dropdown menu not workin in IE. Bug #21252
Modified paths:
  • /trunk/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.php
@@ -18,7 +18,7 @@
1919
2020 /* Configuration */
2121 // Bump the version number every time you change any of the .css/.js files
22 -$wgCollapsibleTabsStyleVersion = 7;
 22+$wgCollapsibleTabsStyleVersion = 8;
2323
2424 /* Setup */
2525
Index: trunk/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.js
@@ -15,7 +15,7 @@
1616 // add the placeholder
1717 $j('<span class="placeholder" style="display:none;"></span>').insertAfter(this);
1818 $j(this).remove().prependTo(target).data('collapsibleTabsSettings', data);
19 - $j(this).attr('style', '');
 19+ $j(this).attr('style', 'display:list-item;');
2020 $j($j(ele).data('collapsibleTabsSettings').expandedContainer).data('collapsibleTabsSettings').shifting = false;
2121 $j.collapsibleTabs.handleResize();
2222 });
@@ -32,7 +32,7 @@
3333 $moving.css("position", "relative").css( ( rtl ? 'right' : 'left'), 0 ).css('width','1px');
3434 $target.replaceWith($moving.remove().css('width','1px').data('collapsibleTabsSettings', data)
3535 .animate({width: expandedWidth+"px"}, "normal", function(){
36 - $j(this).attr('style', '');
 36+ $j(this).attr('style', 'display:block;');
3737 $j($moving.data('collapsibleTabsSettings').expandedContainer).data('collapsibleTabsSettings').shifting = false;
3838 $j.collapsibleTabs.handleResize();
3939 }));

Status & tagging log