r58345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58344‎ | r58345 | r58346 >
Date:22:28, 29 October 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Fix doxygen breakage per CR on r58311
Modified paths:
  • /trunk/extensions/Wikilog/Wikilog.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogComment.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogCommentsPage.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogHooks.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogItem.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogPager.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogQuery.php (modified) (history)
  • /trunk/extensions/Wikilog/WlFeed.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikilog/WikilogQuery.php
@@ -35,18 +35,18 @@
3636 class WikilogItemQuery
3737 {
3838 # Valid filter values for publish status.
39 - const PS_ALL = 0; // /< Return all items
40 - const PS_PUBLISHED = 1; // /< Return only published items
41 - const PS_DRAFTS = 2; // /< Return only drafts
 39+ const PS_ALL = 0; ///< Return all items
 40+ const PS_PUBLISHED = 1; ///< Return only published items
 41+ const PS_DRAFTS = 2; ///< Return only drafts
4242
4343 # Local variables.
44 - private $mWikilogTitle = NULL; // /< Filter by wikilog.
45 - private $mPubStatus = self::PS_ALL; // /< Filter by published status.
46 - private $mCategory = false; // /< Filter by category.
47 - private $mAuthor = false; // /< Filter by author.
48 - private $mTag = false; // /< Filter by tag.
49 - private $mDate = false; // /< Filter by date.
50 - private $mNeedWikilogParam = false; // /< Need wikilog param in queries.
 44+ private $mWikilogTitle = NULL; ///< Filter by wikilog.
 45+ private $mPubStatus = self::PS_ALL; ///< Filter by published status.
 46+ private $mCategory = false; ///< Filter by category.
 47+ private $mAuthor = false; ///< Filter by author.
 48+ private $mTag = false; ///< Filter by tag.
 49+ private $mDate = false; ///< Filter by date.
 50+ private $mNeedWikilogParam = false; ///< Need wikilog param in queries.
5151
5252 # Options
5353 /** Query options. */
Index: trunk/extensions/Wikilog/WlFeed.body.php
@@ -568,9 +568,9 @@
569569 */
570570 class WlTextConstruct
571571 {
572 - const T_TEXT = 'text'; // /< Plain text, no markup.
573 - const T_HTML = 'html'; // /< Contains HTML markup.
574 - const T_XHTML = 'xhtml'; // /< Contains XHTML markup.
 572+ const T_TEXT = 'text'; ///< Plain text, no markup.
 573+ const T_HTML = 'html'; ///< Contains HTML markup.
 574+ const T_XHTML = 'xhtml'; ///< Contains XHTML markup.
575575
576576 /**
577577 * Content language tag.
Index: trunk/extensions/Wikilog/Wikilog.php
@@ -376,14 +376,14 @@
377377 */
378378 class WikilogInfo
379379 {
380 - public $mWikilogName; // /< Wikilog title (textual string).
381 - public $mWikilogTitle; // /< Wikilog main article title object.
382 - public $mItemName; // /< Wikilog post title (textual string).
383 - public $mItemTitle; // /< Wikilog post title object.
384 - public $mItemTalkTitle; // /< Wikilog post talk title object.
 380+ public $mWikilogName; ///< Wikilog title (textual string).
 381+ public $mWikilogTitle; ///< Wikilog main article title object.
 382+ public $mItemName; ///< Wikilog post title (textual string).
 383+ public $mItemTitle; ///< Wikilog post title object.
 384+ public $mItemTalkTitle; ///< Wikilog post talk title object.
385385
386 - public $mIsTalk; // /< Constructed using a talk page title.
387 - public $mTrailing = NULL; // /< Trailing subpage title.
 386+ public $mIsTalk; ///< Constructed using a talk page title.
 387+ public $mTrailing = NULL; ///< Trailing subpage title.
388388
389389 /**
390390 * Constructor.
Index: trunk/extensions/Wikilog/WikilogCommentsPage.php
@@ -47,17 +47,17 @@
4848 extends Article
4949 implements WikilogCustomAction
5050 {
51 - protected $mSkin; // /< Skin used for rendering the page.
52 - protected $mFormOptions; // /< Post comment form fields.
53 - protected $mUserCanPost; // /< User is allowed to post.
54 - protected $mUserCanModerate; // /< User is allowed to moderate.
55 - protected $mPostedComment; // /< Posted comment, from HTTP post data.
56 - protected $mCaptchaForm; // /< Captcha form fields, when saving comment.
57 - protected $mTrailing; // /< Trailing text in comments title page.
 51+ protected $mSkin; ///< Skin used for rendering the page.
 52+ protected $mFormOptions; ///< Post comment form fields.
 53+ protected $mUserCanPost; ///< User is allowed to post.
 54+ protected $mUserCanModerate; ///< User is allowed to moderate.
 55+ protected $mPostedComment; ///< Posted comment, from HTTP post data.
 56+ protected $mCaptchaForm; ///< Captcha form fields, when saving comment.
 57+ protected $mTrailing; ///< Trailing text in comments title page.
5858
59 - public $mItem; // /< Wikilog item the page is associated with.
60 - public $mTalkTitle; // /< Main talk page title.
61 - public $mSingleComment; // /< Used when viewing a single comment.
 59+ public $mItem; ///< Wikilog item the page is associated with.
 60+ public $mTalkTitle; ///< Main talk page title.
 61+ public $mSingleComment; ///< Used when viewing a single comment.
6262
6363 /**
6464 * Constructor.
Index: trunk/extensions/Wikilog/WikilogHooks.php
@@ -268,7 +268,7 @@
269269 if ( $wgDBtype == 'mysql' ) {
270270 $wgExtNewTables[] = array( "wikilog_wikilogs", "{$dir}wikilog-tables.sql" );
271271 } else {
272 - // / TODO: PostgreSQL, SQLite, etc...
 272+ // TODO: PostgreSQL, SQLite, etc...
273273 print "\n" .
274274 "Warning: There are no table structures for the Wikilog\n" .
275275 "extension other than for MySQL at this moment.\n\n";
Index: trunk/extensions/Wikilog/WikilogItem.php
@@ -36,18 +36,18 @@
3737 /**
3838 * General data about the article.
3939 */
40 - public $mID = NULL; // /< Article ID.
41 - public $mName = NULL; // /< Article title text (as in DB).
42 - public $mTitle = NULL; // /< Article Title object.
43 - public $mParent = NULL; // /< Parent wikilog article ID.
44 - public $mParentName = NULL; // /< Parent wikilog title text.
45 - public $mParentTitle = NULL; // /< Parent wikilog Title object.
46 - public $mPublish = NULL; // /< Article is published.
47 - public $mPubDate = NULL; // /< Date the article was published.
48 - public $mUpdated = NULL; // /< Date the article was last updated.
49 - public $mAuthors = array(); // /< Array of authors.
50 - public $mTags = array(); // /< Array of tags.
51 - public $mNumComments = NULL; // /< Cached number of comments.
 40+ public $mID = NULL; ///< Article ID.
 41+ public $mName = NULL; ///< Article title text (as in DB).
 42+ public $mTitle = NULL; ///< Article Title object.
 43+ public $mParent = NULL; ///< Parent wikilog article ID.
 44+ public $mParentName = NULL; ///< Parent wikilog title text.
 45+ public $mParentTitle = NULL; ///< Parent wikilog Title object.
 46+ public $mPublish = NULL; ///< Article is published.
 47+ public $mPubDate = NULL; ///< Date the article was published.
 48+ public $mUpdated = NULL; ///< Date the article was last updated.
 49+ public $mAuthors = array(); ///< Array of authors.
 50+ public $mTags = array(); ///< Array of tags.
 51+ public $mNumComments = NULL; ///< Cached number of comments.
5252
5353 /**
5454 * Constructor.
Index: trunk/extensions/Wikilog/WikilogPager.php
@@ -57,8 +57,8 @@
5858 public $mLimitsShown = array( 5, 10, 20, 50 );
5959
6060 # Local variables.
61 - protected $mQuery = NULL; // /< Wikilog item query data
62 - protected $mIncluding = false; // /< If pager is being included
 61+ protected $mQuery = NULL; ///< Wikilog item query data
 62+ protected $mIncluding = false; ///< If pager is being included
6363
6464 /**
6565 * Constructor.
@@ -377,8 +377,8 @@
378378 implements WikilogPager
379379 {
380380 # Local variables.
381 - protected $mQuery = NULL; // /< Wikilog item query data
382 - protected $mIncluding = false; // /< If pager is being included
 381+ protected $mQuery = NULL; ///< Wikilog item query data
 382+ protected $mIncluding = false; ///< If pager is being included
383383
384384 /**
385385 * Constructor.
Index: trunk/extensions/Wikilog/WikilogComment.php
@@ -36,9 +36,9 @@
3737 /**
3838 * Comment statuses.
3939 */
40 - const S_OK = 'OK'; // /< Comment is published.
41 - const S_PENDING = 'PENDING'; // /< Comment is pending moderation.
42 - const S_DELETED = 'DELETED'; // /< Comment was removed.
 40+ const S_OK = 'OK'; ///< Comment is published.
 41+ const S_PENDING = 'PENDING'; ///< Comment is pending moderation.
 42+ const S_DELETED = 'DELETED'; ///< Comment was removed.
4343
4444 /**
4545 * Mapping of comment statuses to readable messages. System messages are
@@ -58,19 +58,19 @@
5959 /**
6060 * General data about the comment.
6161 */
62 - public $mID = NULL; // /< Comment ID.
63 - public $mParent = NULL; // /< Parent comment ID.
64 - public $mThread = NULL; // /< Comment thread.
65 - public $mUserID = NULL; // /< Comment author user id.
66 - public $mUserText = NULL; // /< Comment author user name.
67 - public $mAnonName = NULL; // /< Comment anonymous author name.
68 - public $mStatus = NULL; // /< Comment status.
69 - public $mTimestamp = NULL; // /< Date the comment was published.
70 - public $mUpdated = NULL; // /< Date the comment was last updated.
71 - public $mCommentPage = NULL; // /< Comment page id.
72 - public $mCommentTitle = NULL; // /< Comment page title.
73 - public $mCommentRev = NULL; // /< Comment revision id.
74 - public $mText = NULL; // /< Comment text.
 62+ public $mID = NULL; ///< Comment ID.
 63+ public $mParent = NULL; ///< Parent comment ID.
 64+ public $mThread = NULL; ///< Comment thread.
 65+ public $mUserID = NULL; ///< Comment author user id.
 66+ public $mUserText = NULL; ///< Comment author user name.
 67+ public $mAnonName = NULL; ///< Comment anonymous author name.
 68+ public $mStatus = NULL; ///< Comment status.
 69+ public $mTimestamp = NULL; ///< Date the comment was published.
 70+ public $mUpdated = NULL; ///< Date the comment was last updated.
 71+ public $mCommentPage = NULL; ///< Comment page id.
 72+ public $mCommentTitle = NULL; ///< Comment page title.
 73+ public $mCommentRev = NULL; ///< Comment revision id.
 74+ public $mText = NULL; ///< Comment text.
7575
7676 /**
7777 * Whether the text was changed, and thus a database update is required.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58311* Some i18n review and preparations for l10n...siebrand13:14, 29 October 2009

Status & tagging log