r58269 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58268‎ | r58269 | r58270 >
Date:18:24, 28 October 2009
Author:overlordq
Status:ok
Tags:
Comment:
(bug 13453) Fix rebuildrecentchanges for DB's with FK constraints
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/rebuildrecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildrecentchanges.php
@@ -186,7 +186,7 @@
187187 'rc_this_oldid' => 0,
188188 'rc_last_oldid' => 0,
189189 'rc_type' => RC_LOG,
190 - 'rc_cur_id' => 'COALESCE(page_id, 0)',
 190+ 'rc_cur_id' => $dbw->cascadingDeletes() ? 'page_id' : 'COALESCE(page_id, 0)',
191191 'rc_log_type' => 'log_type',
192192 'rc_log_action' => 'log_action',
193193 'rc_logid' => 'log_id',
Index: trunk/phase3/RELEASE-NOTES
@@ -666,6 +666,7 @@
667667 * (bug 21085) list=deletedrevs no longer returns only one revision when
668668 drcontinue param is passed
669669 * (bug 21106) Deprecated parameters now tagged in action=paraminfo
 670+* (bug 13453) rebuildrecentchanges maintenance script works on PG again
670671
671672 === Languages updated in 1.16 ===
672673

Follow-up revisions

RevisionCommit summaryAuthorDate
r58553Fix for r58269: move RELEASE-NOTES entry to correct section as this is not AP...ialex17:22, 4 November 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r32226Don't quote the size, it's an int or a literal NULL. Per bug 13453.greg16:49, 20 March 2008
r32227$lastSize is also an int or a literal NULL. Bug 13453.greg16:59, 20 March 2008

Status & tagging log