r58174 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58173‎ | r58174 | r58175 >
Date:23:44, 26 October 2009
Author:adam
Status:deferred
Tags:
Comment:
altering two lines of the code I just commited to match our coding style guide
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -70,15 +70,15 @@
7171 array( 'src' => 'js/plugins/jquery.suggestions.js', 'version' => 5 ),
7272 array( 'src' => 'js/plugins/jquery.textSelection.js', 'version' => 16 ),
7373 array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 12 ),
74 - array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 13 ),
 74+ array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 14 ),
7575 array( 'src' => 'js/plugins/jquery.wikiEditor.dialogs.js', 'version' => 6 ),
7676 array( 'src' => 'js/plugins/jquery.wikiEditor.toc.js', 'version' => 22 ),
7777 ),
7878 'combined' => array(
79 - array( 'src' => 'js/plugins.combined.js', 'version' => 48 ),
 79+ array( 'src' => 'js/plugins.combined.js', 'version' => 49 ),
8080 ),
8181 'minified' => array(
82 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 48 ),
 82+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 49 ),
8383 ),
8484 ),
8585 );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
@@ -462,10 +462,12 @@
463463 $sections.css('overflow', 'hidden');
464464 if ( show ) {
465465 $section.fadeIn( 'fast' );
466 - $sections.animate( { 'height': $section.outerHeight() }, $section.outerHeight() * 2, function() { $(this).css('overflow', 'visible'); } );
 466+ $sections.animate( { 'height': $section.outerHeight() }, $section.outerHeight() * 2, function() {
 467+ $(this).css('overflow', 'visible'); } );
467468 $(this).addClass( 'current' );
468469 } else {
469 - $sections.animate( { 'height': 0 }, $section.outerHeight() * 2, function() { $(this).css('overflow', 'visible'); } );
 470+ $sections.animate( { 'height': 0 }, $section.outerHeight() * 2, function() {
 471+ $(this).css('overflow', 'visible'); } );
470472 }
471473 // Click tracking
472474 if($.trackAction != undefined){
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -2086,10 +2086,12 @@
20872087 $sections.css('overflow', 'hidden');
20882088 if ( show ) {
20892089 $section.fadeIn( 'fast' );
2090 - $sections.animate( { 'height': $section.outerHeight() }, $section.outerHeight() * 2, function() { $(this).css('overflow', 'visible'); } );
 2090+ $sections.animate( { 'height': $section.outerHeight() }, $section.outerHeight() * 2, function() {
 2091+ $(this).css('overflow', 'visible'); } );
20912092 $(this).addClass( 'current' );
20922093 } else {
2093 - $sections.animate( { 'height': 0 }, $section.outerHeight() * 2, function() { $(this).css('overflow', 'visible'); } );
 2094+ $sections.animate( { 'height': 0 }, $section.outerHeight() * 2, function() {
 2095+ $(this).css('overflow', 'visible'); } );
20942096 }
20952097 // Click tracking
20962098 if($.trackAction != undefined){

Follow-up revisions

RevisionCommit summaryAuthorDate
r59204wmf-deployment: Merging usability changes from trunk...catrope18:53, 18 November 2009

Status & tagging log