r58147 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58146‎ | r58147 | r58148 >
Date:16:54, 26 October 2009
Author:btongminh
Status:deferred
Tags:
Comment:
Follow-up to r57868: Add edit.js unconditionally like EditPage does. This will probably unbreak edittools in js2 mode.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -904,14 +904,16 @@
905905 );
906906
907907 $wgOut->addScript( Skin::makeVariablesScript( $scriptVars ) );
908 -
 908+
 909+ // For <charinsert> support; not provided by js2 yet
 910+ $wgOut->addScriptFile( 'edit.js' );
 911+
909912 if ( $wgEnableJS2system ) {
910 - //js2version of upload page:
 913+ // JS2 upload scripts
911914 $wgOut->addScriptClass( 'uploadPage' );
912915 } else {
913 - //legacy upload code:
 916+ // Legacy upload javascript
914917 $wgOut->addScriptFile( 'upload.js' );
915 - $wgOut->addScriptFile( 'edit.js' ); // For <charinsert> support
916918 }
917919 }
918920

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57868Rewrote Special:Upload to allow easier extension. Mostly backwards compatible...btongminh19:41, 18 October 2009

Status & tagging log